add-machine in manual environment without ssh should fail

[Kapil Thangavelu]

else it just leads to garbage in state ala

"14":
   instance: pending
   series: precise

[Dimiter Naydenov (dimitern)]

I'm not sure it *has* to fail - what if you want to add a new container to an existing machine?

[Kapil Thangavelu (hazmat)]

sorry if this was unclear let me clarify, allocating a new machine in a
manual provider environment leads to garbage in state.. ie useless. sure
you can add a container with add-machine, but attempting to add a machine
this way will never work,.

so clarifying, add-machine options that lead to state garbage with no
ability to fulfill a user intent should instead be an error to the user
when they attempt. This just happens to also be the default usage mode of
add-machine without additional parameters.

On Mon, Mar 10, 2014 at 7:56 AM, Dimiter Naydenov <
<email address hidden>> wrote:

> I'm not sure it *has* to fail - what if you want to add a new container
> to an existing machine?
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1256615
>
> Title:
> add-machine in manual environment without ssh should fail
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/juju-core/+bug/1256615/+subscriptions
>

[Dimiter Naydenov (dimitern)]

And now, calling add-machine without arguments actually reports:

ERROR juju.cmd supercommand.go:296 cannot add a new machine: use "juju add-machine ssh:[user@]<host>" to provision machines

[John A Meinel (jameinel)]

Dimiter- should this be considered fixed? Or do we still end up adding
something to state?

On Mon, Mar 10, 2014 at 9:06 PM, Dimiter Naydenov
<email address hidden> wrote:
> And now, calling add-machine without arguments actually reports:
>
> ERROR juju.cmd supercommand.go:296 cannot add a new machine: use "juju
> add-machine ssh:[user@]<host>" to provision machines
>
> --
> You received this bug notification because you are subscribed to juju-
> core.
> https://bugs.launchpad.net/bugs/1256615
>
> Title:
> add-machine in manual environment without ssh should fail
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/juju-core/+bug/1256615/+subscriptions

[Kapil Thangavelu (hazmat)]

looks fixed to me.