ppa builds are built without cgo

Bug #1226902 reported by Andrew Wilkins
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
juju-core
Fix Released
High
James Page

Bug Description

The PPA builds (at least in the dev PPA) are built with CGO_ENABLED=0.

This is what caused bug #1225825. net.LookupIP fails when using the non-cgo version, but not the cgo version. I can (and will) change the code to check if an IP is specified first, but I'm not sure if we should be building without cgo. Since we have different tools for different series (thus we can make guarantees about libc), is there any benefit?

Tags: packaging
Revision history for this message
Dave Cheney (dave-cheney) wrote :

Investigating.

Changed in juju-core:
assignee: nobody → Dave Cheney (dave-cheney)
importance: Undecided → Medium
milestone: none → 1.15.0
status: New → In Progress
Revision history for this message
John A Meinel (jameinel) wrote : Re: [Bug 1226902] Re: ppa builds are built without cgo

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2013-09-18 5:37, Dave Cheney wrote:
> Investigating.
>
> ** Changed in: juju-core Importance: Undecided => Medium
>
> ** Changed in: juju-core Status: New => In Progress
>
> ** Changed in: juju-core Milestone: None => 1.15.0
>
> ** Changed in: juju-core Assignee: (unassigned) => Dave Cheney
> (dave-cheney)
>

I know we want to avoid using CGO for stuff like Windows. But my
personal recommendation would be "it is fine to use if we have it, but
we shouldn't require it".

That said, if we aren't going to use it everywhere, and it has
*functional* differences, then maybe we shouldn't use it anywhere. So
that we discover bugs like this earlier, rather than as some obscure
difference on some different platform.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (Cygwin)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlI5SG4ACgkQJdeBCYSNAAN5/QCeOyTmBnljSRT5uXQNxVqNgh+l
7cAAoMj5MBBEJMNCzvJGjo6zNIeV3f22
=6xMp
-----END PGP SIGNATURE-----

Curtis Hovey (sinzui)
Changed in juju-core:
milestone: 1.15.0 → 1.16.0
Revision history for this message
James Page (james-page) wrote :

The dev PPA was depending on my personal golang backports PPA which is out of date and buggy with reference to CGO.

I've amended the dependencies here:

https://launchpad.net/~juju/+archive/devel/+edit-dependencies

CGO should be OK once you rebuild.

Curtis Hovey (sinzui)
Changed in juju-core:
milestone: 1.16.0 → 2.0
Curtis Hovey (sinzui)
Changed in juju-core:
importance: Medium → High
Curtis Hovey (sinzui)
tags: added: build
Curtis Hovey (sinzui)
tags: added: packaging
removed: build
Curtis Hovey (sinzui)
Changed in juju-core:
assignee: Dave Cheney (dave-cheney) → James Page (james-page)
status: In Progress → Fix Released
milestone: 2.0 → 1.17.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.