Comment 6 for bug 1209594

Revision history for this message
warrior (renjith4) wrote :

Hi Richard,

My understanding was that we will be comparing only the actual classes and not the test classes. When we are writing a comparison tool we could easily ignore all classes under the path 'test' .

The idea of separating tests came up due to the fact that when the test classes are over 200-300 lines of code, it is cumbersome to manage it. There is nothing preventing us from keeping all the test cases in one file but i have seen from my experience that it is very difficult to manage them in future. We can name the tests like USCalendarSettlementTest, USCalendarNasdaqTest etc. This is just a suggestion for increasing the maintainability of code.

To give uniformity we can keep the calendar classes as it is and for the ones with different subdivisions, we can keep different tests which will follow an identifiable naming pattern. This will enable us to compare the tests too if needed in future.

Please let me know your opinion regarding this. If it is too much of work, we can leave the tests as it is (in single test class) and then if needed in future we can divide them in to separate files. This is not a show stopper and so the priority can be low for it.