Comment 5 for bug 1744836

Julia, thanks for testing. I should have looked at it in more detail. That is a Node object, not a db object. I think that the as_dict() that got invoked was from objects.base.IronicObject [1].

wrt the node's instance_info. In this case, we don't need to update it. However, since we're adding a 'secure' to the Node, in the future, someone might use it for something else and assume that the node dict they get back is secure.

The alternative is to figure out what information the agent needs, and only pass it that info. But that'd take us longer to figure out I think.

[1] https://github.com/openstack/ironic/blob/7f64a501c3dd95d20c25e4872226b10dbec207fc/ironic/objects/base.py#L66