The proposed patch does not work and causes cleaning to fail in an unexpected way:
| maintenance | True |
| maintenance_reason | Asynchronous exception for node 4e41df61-84b1-5856-bfb6-6b5f2cd3dd11: |
| | Node failed to start the first cleaning step. Exception: as_dict() got |
| | an unexpected keyword argument 'secure' |
Verified my patched deployment passes unit/py35 tests.
For what is is worth, we don't need to update instance_info. instance_info is wiped in the teardown sequence and if I remember correctly the virt driver code also removes the entries when it tears the node down, so realistically nothing should be present.
The proposed patch does not work and causes cleaning to fail in an unexpected way:
| maintenance | True | 84b1-5856- bfb6-6b5f2cd3dd 11: |
| maintenance_reason | Asynchronous exception for node 4e41df61-
| | Node failed to start the first cleaning step. Exception: as_dict() got |
| | an unexpected keyword argument 'secure' |
Verified my patched deployment passes unit/py35 tests.
For what is is worth, we don't need to update instance_info. instance_info is wiped in the teardown sequence and if I remember correctly the virt driver code also removes the entries when it tears the node down, so realistically nothing should be present.