Timeouts do not work because our database code cannot filter by ID/UUID

Bug #1749755 reported by Ryan on 2018-02-15
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
High
Jim Rollenhagen

Bug Description

This change from lucasagomes has a bug:
https://review.openstack.org/#/c/197141/

In conductor/manager.py, he calls _fail_if_in_state()
and uses the node_id as a filter. However this filter
effectively does nothing because sqalchemy does not
know how to filter by node id on the backend.

Dmitry Tantsur (divius) on 2018-02-15
Changed in ironic:
status: New → Triaged
importance: Undecided → High
summary: - Allow sqalchemy filtering by id and uuid
+ Timeouts do not work because our database code cannot filter by ID/UUID
Changed in ironic:
assignee: nobody → Ryan (rybridges)
status: Triaged → In Progress
Changed in ironic:
assignee: Ryan (rybridges) → Dmitry Tantsur (divius)
Changed in ironic:
assignee: Dmitry Tantsur (divius) → Jim Rollenhagen (jim-rollenhagen)

Reviewed: https://review.openstack.org/545041
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=366a44a1bb4e235f6382af02962ba2a192cffa4d
Submitter: Zuul
Branch: master

commit 366a44a1bb4e235f6382af02962ba2a192cffa4d
Author: Ryan Bridges <email address hidden>
Date: Thu Feb 15 09:01:32 2018 -0800

    Allow sqalchemy filtering by id and uuid

    These additions will allow us to filter nodes
    by node uuid and id. This filter API is used
    in many places throughout the code base. It is
    natural to expect that this API would allow us to
    filter by node id and uuid in addtion to the other
    supported parameters. This also fixes a 3 year old bug.

    This change from lucasagomes has a bug:
    https://review.openstack.org/#/c/197141/

    In conductor/manager.py, he calls _fail_if_in_state()
    and uses the node_id as a filter. However this filter
    effectively does nothing because sqalchemy does not
    know how to filter by node id on the backend. My changes
    fix this problem and make the API more intuitive

    Closes-Bug: #1749755

    Change-Id: I4efc0d5cd5d5d6108a334f954e1718203b47da0a

Changed in ironic:
status: In Progress → Fix Released

Reviewed: https://review.openstack.org/545806
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=1d27478e20239714a69cd219caba698989565ca8
Submitter: Zuul
Branch: stable/queens

commit 1d27478e20239714a69cd219caba698989565ca8
Author: Ryan Bridges <email address hidden>
Date: Thu Feb 15 09:01:32 2018 -0800

    Allow sqalchemy filtering by id and uuid

    These additions will allow us to filter nodes
    by node uuid and id. This filter API is used
    in many places throughout the code base. It is
    natural to expect that this API would allow us to
    filter by node id and uuid in addtion to the other
    supported parameters. This also fixes a 3 year old bug.

    This change from lucasagomes has a bug:
    https://review.openstack.org/#/c/197141/

    In conductor/manager.py, he calls _fail_if_in_state()
    and uses the node_id as a filter. However this filter
    effectively does nothing because sqalchemy does not
    know how to filter by node id on the backend. My changes
    fix this problem and make the API more intuitive

    Closes-Bug: #1749755

    Change-Id: I4efc0d5cd5d5d6108a334f954e1718203b47da0a
    (cherry picked from commit 366a44a1bb4e235f6382af02962ba2a192cffa4d)

tags: added: in-stable-queens
tags: added: in-stable-pike

Reviewed: https://review.openstack.org/545854
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=504a67b46d883545c320847aef6da96f6fa2c607
Submitter: Zuul
Branch: stable/pike

commit 504a67b46d883545c320847aef6da96f6fa2c607
Author: Ryan Bridges <email address hidden>
Date: Thu Feb 15 09:01:32 2018 -0800

    Allow sqalchemy filtering by id and uuid

    These additions will allow us to filter nodes
    by node uuid and id. This filter API is used
    in many places throughout the code base. It is
    natural to expect that this API would allow us to
    filter by node id and uuid in addtion to the other
    supported parameters. This also fixes a 3 year old bug.

    This change from lucasagomes has a bug:
    https://review.openstack.org/#/c/197141/

    In conductor/manager.py, he calls _fail_if_in_state()
    and uses the node_id as a filter. However this filter
    effectively does nothing because sqalchemy does not
    know how to filter by node id on the backend. My changes
    fix this problem and make the API more intuitive

    Closes-Bug: #1749755

    Change-Id: I4efc0d5cd5d5d6108a334f954e1718203b47da0a
    (cherry picked from commit 366a44a1bb4e235f6382af02962ba2a192cffa4d)

tags: added: in-stable-ocata

Reviewed: https://review.openstack.org/545855
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=98b61f4ceed804e222c4cb22b45b23bc35ee833d
Submitter: Zuul
Branch: stable/ocata

commit 98b61f4ceed804e222c4cb22b45b23bc35ee833d
Author: Ryan Bridges <email address hidden>
Date: Thu Feb 15 09:01:32 2018 -0800

    Allow sqalchemy filtering by id and uuid

    These additions will allow us to filter nodes
    by node uuid and id. This filter API is used
    in many places throughout the code base. It is
    natural to expect that this API would allow us to
    filter by node id and uuid in addtion to the other
    supported parameters. This also fixes a 3 year old bug.

    This change from lucasagomes has a bug:
    https://review.openstack.org/#/c/197141/

    In conductor/manager.py, he calls _fail_if_in_state()
    and uses the node_id as a filter. However this filter
    effectively does nothing because sqalchemy does not
    know how to filter by node id on the backend. My changes
    fix this problem and make the API more intuitive

    Closes-Bug: #1749755

    Change-Id: I4efc0d5cd5d5d6108a334f954e1718203b47da0a
    (cherry picked from commit 366a44a1bb4e235f6382af02962ba2a192cffa4d)

This issue was fixed in the openstack/ironic 10.1.1 release.

This issue was fixed in the openstack/ironic 9.1.4 release.

This issue was fixed in the openstack/ironic 7.0.5 release.

This issue was fixed in the openstack/ironic 11.0.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers