Timeouts do not work because our database code cannot filter by ID/UUID
Bug #1749755 reported by
Ryan
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ironic |
Fix Released
|
High
|
Jim Rollenhagen |
Bug Description
This change from lucasagomes has a bug:
https:/
In conductor/
and uses the node_id as a filter. However this filter
effectively does nothing because sqalchemy does not
know how to filter by node id on the backend.
Changed in ironic: | |
status: | New → Triaged |
importance: | Undecided → High |
summary: |
- Allow sqalchemy filtering by id and uuid + Timeouts do not work because our database code cannot filter by ID/UUID |
Changed in ironic: | |
assignee: | nobody → Ryan (rybridges) |
status: | Triaged → In Progress |
Changed in ironic: | |
assignee: | Ryan (rybridges) → Dmitry Tantsur (divius) |
Changed in ironic: | |
assignee: | Dmitry Tantsur (divius) → Jim Rollenhagen (jim-rollenhagen) |
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/545041 /git.openstack. org/cgit/ openstack/ ironic/ commit/ ?id=366a44a1bb4 e235f6382af0296 2ba2a192cffa4d
Committed: https:/
Submitter: Zuul
Branch: master
commit 366a44a1bb4e235 f6382af02962ba2 a192cffa4d
Author: Ryan Bridges <email address hidden>
Date: Thu Feb 15 09:01:32 2018 -0800
Allow sqalchemy filtering by id and uuid
These additions will allow us to filter nodes
by node uuid and id. This filter API is used
in many places throughout the code base. It is
natural to expect that this API would allow us to
filter by node id and uuid in addtion to the other
supported parameters. This also fixes a 3 year old bug.
This change from lucasagomes has a bug: /review. openstack. org/#/c/ 197141/
https:/
In conductor/ manager. py, he calls _fail_if_in_state()
and uses the node_id as a filter. However this filter
effectively does nothing because sqalchemy does not
know how to filter by node id on the backend. My changes
fix this problem and make the API more intuitive
Closes-Bug: #1749755
Change-Id: I4efc0d5cd5d5d6 108a334f954e171 8203b47da0a