Comment 7 for bug 1749755

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (stable/ocata)

Reviewed: https://review.openstack.org/545855
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=98b61f4ceed804e222c4cb22b45b23bc35ee833d
Submitter: Zuul
Branch: stable/ocata

commit 98b61f4ceed804e222c4cb22b45b23bc35ee833d
Author: Ryan Bridges <email address hidden>
Date: Thu Feb 15 09:01:32 2018 -0800

    Allow sqalchemy filtering by id and uuid

    These additions will allow us to filter nodes
    by node uuid and id. This filter API is used
    in many places throughout the code base. It is
    natural to expect that this API would allow us to
    filter by node id and uuid in addtion to the other
    supported parameters. This also fixes a 3 year old bug.

    This change from lucasagomes has a bug:
    https://review.openstack.org/#/c/197141/

    In conductor/manager.py, he calls _fail_if_in_state()
    and uses the node_id as a filter. However this filter
    effectively does nothing because sqalchemy does not
    know how to filter by node id on the backend. My changes
    fix this problem and make the API more intuitive

    Closes-Bug: #1749755

    Change-Id: I4efc0d5cd5d5d6108a334f954e1718203b47da0a
    (cherry picked from commit 366a44a1bb4e235f6382af02962ba2a192cffa4d)