commit 86e3a100a3a6fcfcf9d498886e1d7784f07ecd73
Author: Richard Pioso <email address hidden>
Date: Sun Aug 13 21:10:06 2017 -0400
Fix DRAC classic driver double manage/provide
This change fixes an issue that caused a node using a Dell EMC
integrated Dell Remote Access Controller (iDRAC) classic driver,
'pxe_drac' or 'pxe_drac_inspector', to be placed in the 'clean failed'
state after a double manage/provide cycle, instead of the 'available'
state.
The deploy interface implementation used by iDRAC classic drivers has
been class ironic.drivers.modules.drac.deploy.DracDeploy, which is
derived from class ironic.drivers.modules.iscsi_deploy.ISCSIDeploy. The
only difference between them is that DracDeploy overrides the
prepare_cleaning() method to prevent the booting of the Ironic Python
Agent (IPA) ramdisk when only out-of-band RAID clean steps are
requested. However, it caused the issue and did not have its intended
effect, because Ironic Conductor boots the ramdisk regardless. The
Ironic Conductor should be modified to preclude the booting of the IPA
ramdisk fix, rather than leaving it to individual drivers.
The iDRAC classic drivers' deploy interface implementation has been
changed to ISCSIDeploy. Since class DracDeploy is no longer needed, its
source code and automated tests have been removed.
Reviewed: https:/ /review. openstack. org/493421 /git.openstack. org/cgit/ openstack/ ironic/ commit/ ?id=86e3a100a3a 6fcfcf9d498886e 1d7784f07ecd73
Committed: https:/
Submitter: Jenkins
Branch: master
commit 86e3a100a3a6fcf cf9d498886e1d77 84f07ecd73
Author: Richard Pioso <email address hidden>
Date: Sun Aug 13 21:10:06 2017 -0400
Fix DRAC classic driver double manage/provide
This change fixes an issue that caused a node using a Dell EMC inspector' , to be placed in the 'clean failed'
integrated Dell Remote Access Controller (iDRAC) classic driver,
'pxe_drac' or 'pxe_drac_
state after a double manage/provide cycle, instead of the 'available'
state.
The deploy interface implementation used by iDRAC classic drivers has drivers. modules. drac.deploy. DracDeploy, which is drivers. modules. iscsi_deploy. ISCSIDeploy. The cleaning( ) method to prevent the booting of the Ironic Python
been class ironic.
derived from class ironic.
only difference between them is that DracDeploy overrides the
prepare_
Agent (IPA) ramdisk when only out-of-band RAID clean steps are
requested. However, it caused the issue and did not have its intended
effect, because Ironic Conductor boots the ramdisk regardless. The
Ironic Conductor should be modified to preclude the booting of the IPA
ramdisk fix, rather than leaving it to individual drivers.
The iDRAC classic drivers' deploy interface implementation has been
changed to ISCSIDeploy. Since class DracDeploy is no longer needed, its
source code and automated tests have been removed.
Change-Id: Ib2c9b7f9f780aa f5f6345825b1f6c 9ddb4f9c41f
Closes-Bug: #1676387
Related-Bug: #1572529
Related-Bug: #1705741