Comment 11 for bug 1666009

Reviewed: https://review.openstack.org/469932
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=039225610d220ddb3d9d1edf4a74c8cb2a0de4fd
Submitter: Jenkins
Branch: master

commit 039225610d220ddb3d9d1edf4a74c8cb2a0de4fd
Author: Mark Goddard <email address hidden>
Date: Thu Jun 1 15:24:44 2017 +0100

    Validate portgroup physical network consistency

    When creating or updating a port that is a member of a portgroup, we
    need to validate the consistency of the physical networks of the ports
    in the portgroup.

    There are 3 cases we are interested in:

    - Creating a port which is a member of a portgroup.
    - Updating the physical network of a port which is a member of a
      portgroup.
    - Updating the portgroup of a port.

    All ports in a portgroup should have the same value (which may be None)
    for their physical_network field.

    During creation or update of a port in a portgroup we apply the
    following validation criteria:

    - If the portgroup has existing ports with different physical networks,
      we raise PortgroupPhysnetInconsistent. This shouldn't ever happen.
    - If the port has a physical network that is inconsistent with other
      ports in the portgroup, we raise exception.Conflict.

    If a port's physical network is None, this indicates that ironic's VIF
    attachment mapping algorithm should operate in a legacy (physical
    network unaware) mode for this port or portgroup. This allows existing
    ironic nodes to continue to function after an upgrade to a release
    including physical network support.

    Change-Id: I6a6d248155f98109dd36dba5837494f6974846e6
    Partial-Bug: #1666009