Remove deprecated vendor-passthru lookup and heartbeat

Bug #1640533 reported by Pavlo Shchelokovskyy
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Low
Pavlo Shchelokovskyy
ironic-python-agent
Fix Released
Low
Pavlo Shchelokovskyy

Bug Description

This is a followup to https://bugs.launchpad.net/ironic/+bug/1570841 [RFE] Promote agent vendor passthru to core API

We stated that lookup and heartbeat as vendor-passthru will be removed in Ocata, and now our support policy (one integrated release boundary but at least 3 months) allows us to finally do this.

- Ironic 6.1.0 that introduced the new lookup/heartbeat API was released on Aug 11, 2016
- Newton release was done on Oct 6, 2016

This bug is created to track this effort.

Changed in ironic:
assignee: nobody → Pavlo Shchelokovskyy (pshchelo)
Changed in ironic-python-agent:
assignee: nobody → Pavlo Shchelokovskyy (pshchelo)
Changed in ironic-python-agent:
status: New → In Progress
Revision history for this message
Pavlo Shchelokovskyy (pshchelo) wrote :

Patch to IPA removing vendor-passthru lookup/heartbeat support
https://review.openstack.org/#/c/386052/

Changed in ironic:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic-python-agent (master)

Reviewed: https://review.openstack.org/386052
Committed: https://git.openstack.org/cgit/openstack/ironic-python-agent/commit/?id=b033bfd933b1cd52b3493ce3b1962ba262a882b7
Submitter: Jenkins
Branch: master

commit b033bfd933b1cd52b3493ce3b1962ba262a882b7
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Thu Oct 13 18:23:20 2016 +0300

    Remove old lookup/heartbeat from IPA

    Lookup/Heartbeat via vendor passthru was deprecated in Newton.

    This patch removes the corresponding functionality from IPA,
    and also removes handling of 'ipa-driver-name' kernel parameter,
    as it was only used in code related to old passthru.

    Change-Id: I2c7989063ab3e4c0bae33f05d6d2ed857a2d9944
    Closes-Bug: #1640533

Changed in ironic-python-agent:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/387402
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=c0bdda98378fe8a6e5619140c25e905193828681
Submitter: Jenkins
Branch: master

commit c0bdda98378fe8a6e5619140c25e905193828681
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Mon Oct 17 14:51:37 2016 +0300

    Do not pass ipa-driver-name as kernel parameter

    This was used for old vendor-passthru heartbeat only, which is now
    deprecated.

    Change-Id: I490f7a0acfb075293148545a2253e3e8f5e15111
    Depends-On: I2c7989063ab3e4c0bae33f05d6d2ed857a2d9944
    Partial-Bug: #1640533

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/397843

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/397844

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/397845

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/397846

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to ironic (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/397847

Changed in ironic:
assignee: Pavlo Shchelokovskyy (pshchelo) → Xavier (marcusrafael)
Changed in ironic:
assignee: Xavier (marcusrafael) → Pavlo Shchelokovskyy (pshchelo)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/397843
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=f03f3feb759dad7b7814704127acca6f4aa62f85
Submitter: Jenkins
Branch: master

commit f03f3feb759dad7b7814704127acca6f4aa62f85
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Tue Nov 15 13:58:04 2016 +0200

    Move `deploy_forces_oob_reboot` to deploy drivers

    Currently this driver option is exported by agent vendor interface which
    is about to be removed.

    Change-Id: I44e6ce39163d13d1e687bca3953a4bafe1e1be6d
    Partial-Bug: #1640533

Changed in ironic:
importance: Undecided → Low
Changed in ironic-python-agent:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/397844
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=206e246d257714f5928c46d0dcf9dc6bf95b84de
Submitter: Jenkins
Branch: master

commit 206e246d257714f5928c46d0dcf9dc6bf95b84de
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Tue Nov 15 14:00:24 2016 +0200

    Remove agent vendor passthru from most drivers

    This patch removes the deprecated agent lookup/heartbeat as vendor
    passthru functionality from most of the drivers in following modules:
    - ironic.drivers.agent
    - ironic.drivers.pxe
    - ironic.drivers.drac
    - ironic.drivers.irmc

    Some drivers are left untouched though:
    - iLO and OneView drivers are a bit more complicated and will be fixed
      in follow-up patches
    - iBoot, WoL and AMT drivers will be fixed in ironic-staging-drivers
      repo first and then removed from ironic tree.

    Change-Id: Ia9ee46cda68ef823d1fe8e5ea03c1d5948810a50
    Partial-Bug: #1640533

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/397845
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=679edb4e7294604d6aded9baa76a87056eb23ec3
Submitter: Jenkins
Branch: master

commit 679edb4e7294604d6aded9baa76a87056eb23ec3
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Tue Nov 15 11:24:59 2016 +0200

    Remove agent vendor passthru from iLO drvers

    Change-Id: Ic686eaa744bf2c9eac44fe3c437ebb67e6153489
    Partial-Bug: #1640533

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/397846
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=cf81c491f385198e967ce7aec6f2266e3b50e5e8
Submitter: Jenkins
Branch: master

commit cf81c491f385198e967ce7aec6f2266e3b50e5e8
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Tue Nov 15 12:15:02 2016 +0200

    Remove agent vendor passthru from OneView drivers

    Change-Id: I811508fb1636f1c36a20a679e6555739c68ce7da
    Partial-Bug: #1640533

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to ironic (master)

Reviewed: https://review.openstack.org/397847
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=87c2db4dc6c87cb130b754184344878d951fbb7d
Submitter: Jenkins
Branch: master

commit 87c2db4dc6c87cb130b754184344878d951fbb7d
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Tue Nov 15 12:21:20 2016 +0200

    Remove iBoot, WoL and AMT drivers

    This patch removes the mentioned drivers from ironic code tree.

    Per our third-party drivers policy they are unsupported,
    and there is no existing plan to have third-party CI for them.

    Nevertheless, if anybody still needs them, they are available in
    ironic-staging-drivers repo.

    Change-Id: I1219892bbc1b814d80b62c8ec89b90819071870f
    Related-Bug: #1640533

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/397848
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=5eb4ba26ddbde97758511c9b61046e5a879ab66c
Submitter: Jenkins
Branch: master

commit 5eb4ba26ddbde97758511c9b61046e5a879ab66c
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Tue Nov 15 13:13:10 2016 +0200

    Remove agent vendor passthru completely

    This patch removes all the basic classes for lookup/heartbeat as vendor
    passthru from Ironic code, as well as removes those API endpoints from
    list of API public routes.

    It also removes the agent vendor passthru from fake drivers.

    Change-Id: Ia133a63ed4e8ed99551f6d2656d24e990300f3a2
    Closes-Bug: #1640533

Changed in ironic:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to ironic-python-agent (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/427126

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to ironic-python-agent (master)

Reviewed: https://review.openstack.org/427126
Committed: https://git.openstack.org/cgit/openstack/ironic-python-agent/commit/?id=5b1a217195e2b282ccbf7989b6ff4213a7dca478
Submitter: Jenkins
Branch: master

commit 5b1a217195e2b282ccbf7989b6ff4213a7dca478
Author: Mathieu Mitchell <email address hidden>
Date: Tue Jan 31 07:02:59 2017 -0500

    Remove vendor_passthru mentions from lookup/heartbeat documentation

    Currently, the documentation index provides the old lookup/heartbeat
    URLs. Commit b033bfd9 removed usage for these URLs.

    This commit replaces old URLs from docs with the ones actually used.

    Change-Id: I375045c23663768e4971d76162c87b731ee82eb3
    Related-bug: #1640533

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ironic 7.0.0

This issue was fixed in the openstack/ironic 7.0.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ironic-python-agent 2.0.0

This issue was fixed in the openstack/ironic-python-agent 2.0.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to ironic (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/460742

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to ironic (master)

Reviewed: https://review.openstack.org/460742
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=bbb8d3d00587ee0f835a803a1393ceaffa98251a
Submitter: Jenkins
Branch: master

commit bbb8d3d00587ee0f835a803a1393ceaffa98251a
Author: Ruby Loo <email address hidden>
Date: Thu Apr 27 16:48:45 2017 -0400

    [api-ref] remove reference to old lookup/heartbeat

    Vendor-passthru lookup and heartbeat have been removed (in
    5eb4ba26ddbde97758511c9b61046e5a879ab66c). This removes references
    to them.

    Change-Id: I3565999f129cf88c2aa5f04bbf27eaa0da6dc588
    Related-Bug: #1640533

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to ironic (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/465708

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/469629

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to ironic (master)

Reviewed: https://review.openstack.org/465708
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=24006badee14ba4bc45df6cd70d059a49b82a4a7
Submitter: Jenkins
Branch: master

commit 24006badee14ba4bc45df6cd70d059a49b82a4a7
Author: Ruby Loo <email address hidden>
Date: Wed May 17 15:03:39 2017 -0400

    Remove remaining vendor passthru lookup/heartbeat

    Vendor-passthru lookup and heartbeat was mostly removed (in
    5eb4ba26ddbde97758511c9b61046e5a879ab66c). This removes the
    remaining code and references to them.

    Change-Id: I6b214503999ce1892f10f4507a6063b6e8d604bc
    Related-Bug: #1640533

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on ironic (stable/newton)

Change abandoned by Fellype Cavalcante (<email address hidden>) on branch: stable/newton
Review: https://review.openstack.org/469629

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.