[RFE] Promote agent vendor passthru to core API

Bug #1570841 reported by Dmitry Tantsur on 2016-04-15
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Wishlist
Jim Rollenhagen

Bug Description

Create unauthenticated API endpoints

 /v1/nodes/lookup
 /v1/nodes/<UUID>/heartbeat

Extend the deploy interface with

 def lookup(self, inventory, uuid=None):
 def heartbeat(self, callback_url):

which will get called by these endpoints.

Fix proposed to branch: master
Review: https://review.openstack.org/330018

Changed in ironic:
status: Confirmed → In Progress

Fix proposed to branch: master
Review: https://review.openstack.org/330938

Reviewed: https://review.openstack.org/306418
Committed: https://git.openstack.org/cgit/openstack/ironic-specs/commit/?id=b528dc918991bba5ac7d6c39c8ed982039ce6124
Submitter: Jenkins
Branch: master

commit b528dc918991bba5ac7d6c39c8ed982039ce6124
Author: Dmitry Tantsur <email address hidden>
Date: Fri Apr 15 15:18:37 2016 +0200

    Promote agent vendor passthru to core API

    Change-Id: Ifa4a1936845198a61d7901b9580829fd1ccde65b
    Related-Bug: #1570841

Dmitry Tantsur (divius) on 2016-06-17
tags: added: rfe-approved
removed: rfe

Fix proposed to branch: master
Review: https://review.openstack.org/333964

Reviewed: https://review.openstack.org/330938
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=088f09903b310fe66cb76f1c5bd62f1ac076dd53
Submitter: Jenkins
Branch: master

commit 088f09903b310fe66cb76f1c5bd62f1ac076dd53
Author: Dmitry Tantsur <email address hidden>
Date: Fri Jun 17 09:42:33 2016 +0200

    Add dbapi and objects functions to get a node by associated MAC addresses

    Adds a new dbapi call get_node_by_port_addresses and associated objects call
    Node.get_by_port_addresses. The logic is the same as in "lookup" agent passthru.

    Will be used for a new lookup endpoint.

    Change-Id: Ia5549fb16cd363f3492b9ca0400177c92a1aea19
    Partial-Bug: #1570841

Reviewed: https://review.openstack.org/332890
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=97f96642a9a85e3d6d638ddabb0586ec5902b614
Submitter: Jenkins
Branch: master

commit 97f96642a9a85e3d6d638ddabb0586ec5902b614
Author: Dmitry Tantsur <email address hidden>
Date: Wed Jun 22 17:58:35 2016 +0200

    Introduce new driver call and RPC for heartbeat

    Change-Id: Iec31feb07b85f9ed668d354967f8d265233a2bc1
    Partial-Bug: #1570841

Reviewed: https://review.openstack.org/333964
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=a9216bb07f4ccd4dc202fd1f5c14b36a08ac6046
Submitter: Jenkins
Branch: master

commit a9216bb07f4ccd4dc202fd1f5c14b36a08ac6046
Author: Dmitry Tantsur <email address hidden>
Date: Fri Jun 24 17:24:58 2016 +0200

    Implement new heartbeat for AgentDeploy

    Refactor heartbeat and related calls to a new AgentDeployMixin used
    in AgentDeploy, ISCSIDeploy and BaseAgentVendor.

    Also removes excessive passing of kwargs to where they are not used.
    It has a potential of breaking out-of-tree drivers, but it also greatly
    simplifies tracking how values are passed during deployment.

    Also made several methods just functions.

    Change-Id: I56c728c13b06f1aea0baeec0dddc7ba160a7a211
    Partial-Bug: #1570841

Changed in ironic:
assignee: Dmitry Tantsur (divius) → Jim Rollenhagen (jim-rollenhagen)
Changed in ironic:
assignee: Jim Rollenhagen (jim-rollenhagen) → Dmitry Tantsur (divius)

Reviewed: https://review.openstack.org/330018
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=8bdd538c0c387c8c2633c8615f2a15a31918a548
Submitter: Jenkins
Branch: master

commit 8bdd538c0c387c8c2633c8615f2a15a31918a548
Author: Dmitry Tantsur <email address hidden>
Date: Wed Jun 15 17:30:33 2016 +0200

    Promote agent vendor passthru to core API

    Introduces new /v1/lookup and /v1/heartbeat/<UUID> endpoints
    (and associated controllers).

    This change does not deprecate the old passthru endpoints, it should
    be done after IPA switches to using the new ones.

    Change-Id: I9080c07b03103cd7a323e2fc01be821733b07eea
    Partial-Bug: #1570841

Changed in ironic:
assignee: Dmitry Tantsur (divius) → Jim Rollenhagen (jim-rollenhagen)

Reviewed: https://review.openstack.org/336547
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=2f84daaa6f34ba52e0b5660c2233e9c5ba04b98a
Submitter: Jenkins
Branch: master

commit 2f84daaa6f34ba52e0b5660c2233e9c5ba04b98a
Author: Dmitry Tantsur <email address hidden>
Date: Fri Jul 1 14:59:59 2016 +0200

    Officially deprecate agent passthru classes and API

    We've introduced the new set of API endpoints for lookup and heartbeat
    which all drivers should implement now and all ramdisk should use.

    IPA switched to the new API in the Newton release. The deprecated passthru
    endpoints and classes will be removed in the Ocata release.

    Change-Id: If0d189ecdd4b84d1dbac274e6dec200e13dfe37c
    Depends-On: I7160c99ca63585fc333482fa578fdf5e0962b2b6
    Closes-Bug: #1570841

Changed in ironic:
status: In Progress → Fix Released

This issue was fixed in the openstack/ironic 6.1.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers