[inspection] wait for the PXE DHCP by default and remove the carrier check
We hoped that checking /sys/class/net/XXX/carrier will allow us
to not wait for interfaces that are not connected at all.
In reality this field turned out to be unreliable. For example, it is
also set to 0 when interface is down or is being configured.
The bug https://bugzilla.redhat.com/show_bug.cgi?id=1327255 shows
the case when carrier is 0 for all interfaces, including one that is
used to post back data, which is obvious non-sense.
This change removes check on carrier for the loop. To avoid 60 seconds
wait for people with several NIC's, it's changed to only wait for the
PXE booting NIC, which obviously must get an IP address.
This makes IP addresses in the inspection data for other NIC's somewhat
unreliable. A new option inspection_dhcp_all_interfaces is introduced
to allow waiting for all NIC's to get IP addresses.
Reviewed: https:/ /review. openstack. org/313511 /git.openstack. org/cgit/ openstack/ ironic- python- agent/commit/ ?id=6da6ace3840 d56c7145ddf528b bdcbb813fc6ce2
Committed: https:/
Submitter: Jenkins
Branch: master
commit 6da6ace3840d56c 7145ddf528bbdcb b813fc6ce2
Author: Dmitry Tantsur <email address hidden>
Date: Fri May 6 13:26:44 2016 +0200
[inspection] wait for the PXE DHCP by default and remove the carrier check
We hoped that checking /sys/class/ net/XXX/ carrier will allow us /bugzilla. redhat. com/show_ bug.cgi? id=1327255 shows
to not wait for interfaces that are not connected at all.
In reality this field turned out to be unreliable. For example, it is
also set to 0 when interface is down or is being configured.
The bug https:/
the case when carrier is 0 for all interfaces, including one that is
used to post back data, which is obvious non-sense.
This change removes check on carrier for the loop. To avoid 60 seconds
wait for people with several NIC's, it's changed to only wait for the
PXE booting NIC, which obviously must get an IP address.
This makes IP addresses in the inspection data for other NIC's somewhat dhcp_all_ interfaces is introduced
unreliable. A new option inspection_
to allow waiting for all NIC's to get IP addresses.
This change should finally fix bug 1564954.
Change-Id: I8b04bf726980fd cf6bd536c6bb28e 30ac50658fb
Related-Bug: #1564954