Comment 2 for bug 1564954

Reviewed: https://review.openstack.org/300548
Committed: https://git.openstack.org/cgit/openstack/ironic-python-agent/commit/?id=3deb25a3cec7955c5e38d83af74add58478f884c
Submitter: Jenkins
Branch: master

commit 3deb25a3cec7955c5e38d83af74add58478f884c
Author: Dmitry Tantsur <email address hidden>
Date: Fri Apr 1 16:36:01 2016 +0200

    Wait for the interfaces to get IP addresses before inspection

    In the DIB build the DHCP code (provided by the dhcp-all-interfaces element)
    races with the service starting IPA. It does not matter for deployment itself,
    as we're waiting for the route to the Ironic API to appear. However, for
    inspection it may result in reporting back all NIC's without IP addresses.
    Inspection fails in this case.

    This change makes inspection wait for *all* NIC's to get their IP addresses up
    to a small timeout. The timeout is 60 seconds by default and can be changed
    via the new ipa-inspection-dhcp-wait-timeout kernel option (0 to not wait).

    After the wait inspection proceedes in any case, so the worst downside
    is making inspection 60 seconds longer.

    To avoid waiting for NIC's that are not even connected, this change extends the
    NetworkInterface class with 'has_carrier' field.

    Closes-Bug: #1564954
    Change-Id: I5bf14de4c1c622f4bf6e3eadbe20c44759da5d66