Comment 4 for bug 337105

Revision history for this message
Gael Varoquaux (gael-varoquaux) wrote : Re: [Bug 337105] Re: Exception hook should be optional for embedding IPython in GUIs

On Sat, Mar 14, 2009 at 12:52:18PM -0000, Fernando Perez wrote:
> Closing as won't fix since the solution is more of a workaround. As we
> refactor things, we can offer later a nicer way to do this. But I'm
> happy to close for now.

> ** Changed in: ipython
> Status: New => Won't Fix

I have just implemented this in the Enthought codebase (will move it up
to the frontend code in IPython soon).

This is simply _horrible_: module-level monkey patching. In other words:
huge side effects. I don't think this solution is acceptabe, and I'd like
this bug reopened, admitedly with a milestone set for later than 0.10.

The IPython-related code in ETS is full of similar hacks (like
monkey-patching raw_input). It renders the whole applications fragiles.

Gaël