Comment 7 for bug 979208

Revision history for this message
su_v (suv-lp) wrote :

I was just recently thinking about your proposed version…
- Would you retract or keep the separate 'Randomize…' extension if you combine it to 'HSL edit/Adjust'? I hadn't really considered whether combined adjustments e.g. modulating the hue while randomizing saturation / lightness slightly are much more frequently used adjustments, than simply adjusting the hue by itself, or along with saturation? I'm not against using your combined one - just that I'm a bit more conservative wrt removing existing extensions (and their verbs, usable in old scripting or via dbus API).
- Redundant ranges in 'Hue rotate': I was never quite sure whether to use 180° or 360° for hue rotate, and had settled with the scheme used in the raster extension (HSB Adjust) [1], also because it allows to mentally spin/rotate the color wheel in either direction without doing any additionally math.
For saturation and lightness, I chose -100/+100 - unlike in the raster extension (not sure if I'm miserably failing in math, or -200/+200 is indeed the equivalent to the redundant range for hue rotate (assuming the normal range for saturation and lightness/brightness is '0 - 100%', also in ImageMagick++)).

[1] <http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/view/head:/src/extension/internal/bitmap/modulate.cpp#L36>