Patch committed in trunk revision 11152 along with the following modifications:
- check on colors size changed in empty check (should be better according to the code checker cppcheck: " Checking for 'colors' emptiness might be inefficient. Using colors.empty() instead of colors.size() can be faster. colors.size() can take linear time but colors.empty() is guaranteed to take constant time.")
- I additionally converted some existing c-type variable casts to their c++ counterparts
Thanks for the patch.
Patch committed in trunk revision 11152 along with the following modifications:
- check on colors size changed in empty check (should be better according to the code checker cppcheck: " Checking for 'colors' emptiness might be inefficient. Using colors.empty() instead of colors.size() can be faster. colors.size() can take linear time but colors.empty() is guaranteed to take constant time.")
- I additionally converted some existing c-type variable casts to their c++ counterparts