Changing a layer's name is not treated as a file modification

Bug #806302 reported by Jonathan Bohren
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
Low
Veronika Irvine

Bug Description

In Inkscape 0.47 and 0.48.1 (r9760), if the user only changes a layer name, the program does not register the modification as a change to the file and therefore will not allow the user to save the changes. In order to save a layer name modification, the user must also change some other content of the document.

Tags: layers ui undo

Related branches

Revision history for this message
su_v (suv-lp) wrote :

Reproduced with Inkscape 0.48.1 and 0.48+devel r10419 on Mac OS X 10.5.8 (i386)
Only occurs when editing the layer name in the list view.
Not reproduced when using the menu command ('Layers > Rename layer…') or the context menu command in the list view.

Same issue already discussed in
Bug #377294 “rename layer which has no inkscape:label attribute fails” (comment #1 et seq.)

tags: added: layers ui
tags: added: undo
Changed in inkscape:
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
Veronika Irvine (vmi) wrote :

This patch adds the "rename layer" operation of the Layer list to the undo history. This causes the document to be marked as having unsaved changes and also enables the undo/redo of the layer rename.

This is the same code that is used in the Layer dialog for renaming (see layer-properties.cpp LayerPropertiesDialog::Rename::perform).

Revision history for this message
ScislaC (scislac) wrote :

Patch committed in r11091. Thanks Veronika! Sending you a PM from the Contact User link on your LP account regarding commit access.

Changed in inkscape:
milestone: none → 0.48.4
status: Confirmed → Fix Committed
Revision history for this message
Kris (kris-degussem) wrote :

Backport was committed in revision 9887.

su_v (suv-lp)
Changed in inkscape:
assignee: nobody → Veronika Irvine (vmi)
Ted Gould (ted)
Changed in inkscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.