Comment 3 for bug 674109

Revision history for this message
su_v (suv-lp) wrote :

Patch tested with Inkscape 0.48+devel r9899 on OS X 10.5.8
(compared to 0.48.0 and 0.48+devel r9901 without patch):

While it prevents pattern definition spam (on text as well as groups), it changes how the same pattern is defined for new objects:
1) Without patch, applying a (stock) pattern that is already used in the document to a new object resets the transform parameters. With the patch, the pattern uses the last used transforms for that pattern in the document and cannot be reset to the original parameters.
2) Same happens when changing the fill attribute of a pattern-filled object to solid and back to pattern again:
Without the patch the parameters are reset (same pattern though). With the patch, the same pattern is reapplied, but with the last used pattern transforms (globally) of that specific pattern.

I don't think this side-effect was intentional - could you investigate if this can be prevented? OTOH - possibly it indicates a solution for bug #370049 “Pattern fill type setting is lost when selecting another fill type”.

Would you agree on this expected behavior?
1) pattern applied to new object: default parameters (unless style is copied from another object)
2) pattern reapplied to object (after switching fill type): reuse prior parameters (if possible)