Comment 4 for bug 649441

Hi,

Thanks for testing that patch out. You're good at finding bugs!

1) This shouldn't be an issue, as far as I can tell (I'm open to correction from someone that may know better!). The dialogs with live preview are non-modal anyway, and these extensions don't have to be written any differently, they just have to enable the checkbox. There is a small modal dialog that pops up when the extension is actually running, which prevents things getting out of sync. Changes made since the extension starting, finishing and replacing the document are impossible. I guess this has been added since that message no the mailing list, but I haven't checked that out.

2) This is a transaction bug unaffected by this patch, which existed before my patch and will not be fixed by this patch of course. You may find that the answer to point 3 (following), will reinstate the original function call order, making the backtrace go back to as it was. I may look at it eventually, but it will involve me learning a bit more about the ins and outs of the undo system.

3) I've updated the patch and the new crash (item 3 on your list) doesn't happen any more for me (Win7, trunk rev9800)