Comment 33 for bug 381677

Revision history for this message
Patrick Storz (ede123) wrote :

Just stumbled across this issue myself and tested the patch.

It seems to work as expected, however I think it's unnecessary to iterate over all items (which are hidden anyway)? I therefore suggest the simplified version attached unless I'm missing something.

Only nitpick (in both the original patch as well as in the one I provided):
The function "sp_generate_internal_bitmap()" which we modify to reset opacity is used by other dependent code as well. All of that code does not use the "item_only" parameter (so nothing changes at this time) but I guess we should consider an additional boolean like "reset_opacity" anyway to avoid side effects.