(From update of attachment 390669)
(In reply to comment #64)
> (In reply to comment #63)
> > + // have we run off the end of the path?
> > + if (pos.x + halfAdvance > length)
> > + break;
> >
> > Is it possible for us to go past the end of the path but then negative dx
> > pulls us back into the path?
>
> Fixed.
Can you add a test for this? Generally I think it's good to create regression tests even for the bugs you find during development before checking in.
> > You're not handling 'rotate' for text on a path?
>
> Fixed.
You don't seem to have any tests for rotate? We need tests with and without a path.
> > Can't GetDx/GetDy/GetRotate just return a non-addrefed pointer?
>
> I'm going to punt that to whatever fix addresses
> nsIDOMSVGLengthList/nsIDOMSVGNumberList if that's OK.
(From update of attachment 390669)
(In reply to comment #64)
> (In reply to comment #63)
> > + // have we run off the end of the path?
> > + if (pos.x + halfAdvance > length)
> > + break;
> >
> > Is it possible for us to go past the end of the path but then negative dx
> > pulls us back into the path?
>
> Fixed.
Can you add a test for this? Generally I think it's good to create regression tests even for the bugs you find during development before checking in.
> > You're not handling 'rotate' for text on a path?
>
> Fixed.
You don't seem to have any tests for rotate? We need tests with and without a path.
> > Can't GetDx/GetDy/ GetRotate just return a non-addrefed pointer? List/nsIDOMSVGN umberList if that's OK.
>
> I'm going to punt that to whatever fix addresses
> nsIDOMSVGLength
OK
r+ assuming those tests are added.