should be okay to name layers with same label

Bug #339660 reported by Halley
4
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
Medium
John Smith

Bug Description

In earlier versions of Inkscape, the name of layers was implemented as the id="layer3" attribute. This meant that layer names had to be unique, since id="" attribute values are used to uniquely identify any and all elements in the file. (See old bugs https://bugs.launchpad.net/bugs/166271 and https://bugs.launchpad.net/bugs/170944 about this old scheme.)

Now, Inkscape does not depend on id="" for the layer names shown in the Layers dialog. Instead, the id="" is a unique identifier for scripts and xml handling, and the inkscape:label="My Friendly Layer Name" attribute is shown in the Layers dialog.

There is no technical reason for layer names (inkscape:label="" attribute values) to be unique, and it can be limiting for the user to get artificially-numbered names like "Coloring#3". Also see https://bugs.launchpad.net/bugs/171723 which expresses a similar sentiment.

(Also according to https://bugs.launchpad.net/bugs/168351 and https://bugs.launchpad.net/bugs/168506 the layer renaming feature has not fully caught up to this scheme. If a layer is renamed but had no inkscape:label, then the new name is actually not committed anywhere and the new name is lost when the program closes the file.)

I'm proposing (and patching) Inkscape to behave this way:

  * internal id="" attributes must be unique, no change

  * duplicated layers change their label to be initially unique (inkscape:label="My Layer copy"), no change

  * new layers get new unique labels (inkscape:label="Layer #3") instead of depending on id="" (fix)

  * user is able to rename labels to be non-unique in xml editor and changes show up in layers dialog, no change

  * user is able to rename labels to be non-unique in Layers dialog (fix)

Tags: layers
Changed in inkscape:
importance: Undecided → Medium
milestone: none → 0.47
status: New → Confirmed
Revision history for this message
Rena Kunisaki (i-am-inuyasha) wrote :

This is true, but it'd be nice to have the option to still enforce unique names, as it can be confusing otherwise.

Revision history for this message
Jon A. Cruz (jon-joncruz) wrote :

We've been told by numerous sources that this is not really confusing after all, even for artists. Also it turned out GIMP was the only graphics program we could find that had the unique name behavior. Photoshop and others did not.

ScislaC (scislac)
Changed in inkscape:
milestone: 0.47 → none
jazzynico (jazzynico)
tags: added: layers
Revision history for this message
John Smith (john-smithi) wrote :

Can this bug be closed ?
It appears the current behavior (0.47+devel r11040) matches the original proposal :

* duplicated layers change their label to be initially unique (inkscape:label="My Layer copy")
* new layers get new unique labels (inkscape:label="Layer #3")
* user is able to rename labels to be non-unique in xml editor/rename dialog/in place in Layers dialog

Revision history for this message
su_v (suv-lp) wrote :

> Can this bug be closed ?

Honestly, I'm not sure:
If fully implementing the proposal only depends on bug #168351 (fix committed in r11039), the status would be 'Fix Committed' and milestoned to 0.49 (I haven't fully verified against current stable 0.48.3.1).

If bug #168506 (marked as duplicate of #377294) also affects one of the proposed behaviors, this report should probably kept open: layers without or with an empty 'inkscape:label' attribute cannot be renamed (except by manually adding the attribute and its value in the XML Editor) - still present in current trunk (r11040).

Revision history for this message
ScislaC (scislac) wrote :

Yes, I think this bug should be closed as it stands...
The https://bugs.launchpad.net/bugs/168506 issue still exists, but is not the same problem.

Changed in inkscape:
status: Confirmed → Fix Committed
assignee: nobody → John Smith (john-smithi)
milestone: none → 0.49
Bryce Harrington (bryce)
Changed in inkscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.