Comment 8 for bug 259303

Revision history for this message
Jon A. Cruz (jon-joncruz) wrote :

I've given it a quick review, and while the overall is looking good, there are a lot of little details that need to be figured out and addressed before we commit. One quick example is hardcoded buffer sizes for paths and suck. There is a hardcoded array of only 1k, but Linux usually may pass up to 4k, and BSD has been seen to use 16K. Also the current code will not operate correctly on MS Windows.