Comment 3 for bug 226001

Revision history for this message
Rygle (rygle) wrote :

Nice work inductive! 3 comments at this stage

First, to get this to work in 0.46 devel or later, you have to add the xml namespace lines to the top;
replace;
===
<inkscape-extension>
===
with
===
<?xml version="1.0" encoding="UTF-8"?>
<inkscape-extension xmlns="http://www.inkscape.org/namespace/inkscape/extension">
===

Second, once I do that, it gets this error using default values and the third mode (sides a,b, angle a);
===
Traceback (most recent call last):

  File "D:\Download\Multimedia\Image\Inkscape\compiling\SVN\trunk\inkscape\share\extensions\triangle.py", line 197, in <module>

    e.affect()

  File "D:\Download\Multimedia\Image\Inkscape\compiling\SVN\trunk\inkscape\share\extensions\inkex.py", line 154, in affect

    self.effect()

  File "D:\Download\Multimedia\Image\Inkscape\compiling\SVN\trunk\inkscape\share\extensions\triangle.py", line 155, in effect

    error=false

NameError: global name 'false' is not defined
===

Third, I noticed there's no GPL2 or better statement in the .py file like in your grid extensions. Are you happy for that to go in?

Once we get those sorted out, we (I) will also add entries to /share/extensions/Makefile.am and /po/POTFILES.in

Sas might also like to check the xml. He had some very slight corrections to the two grid*.inx files. You can see the latest versions of them here;
http://inkscape.svn.sourceforge.net/viewvc/inkscape/inkscape/trunk/share/extensions/