Inkscape Preferences dialog does not remember tabs/pages

[bbyak]

Now it always opens with an empty page. It must remember the last opened page, and when I doubleclick the tool button it must open on that tool's options page. In 0.45 this worked, so this is a regression.

[Maximilian Albert (cilix)]

AFAICT this is due to the dialog refactoring. The reason for this seems to be the following:

- In ui/dialog/inkscape-preferences.cpp, line 111, the function _presentPages() is connected to the present() method of the Panel class.
- However, the dialogs are shown by using the present() method of the Dialog class (or some other, not 100% sure).
- Therefore, _presentPages() is not called any more when the dialog is presented so that the tools' pages are not correctly updated.

I hope this analysis is right (couldn't inspect too closely). I couldn't find an easy way to fix it, though, that's why I'm writing up my thoughts here for anyone to pick them up. BTW, if this is fixed it may (or may not) close some related bugs, too (e.g., I believe that #184499 is caused by the same thing).

[gustav_b (gustav-b)]

Thanks Maximilian, fixed in 17207.

[su_v (suv-lp)]

Inkscape 0.46+devel r21615 on OS X 10.5.7
Reopening -> regression.

When Preferences > Windows > Dialog behaviour is set to 'Floating', no tabs are remembered nor is the tool's page opened when double-clicking the tool button. (Works as expected when Dialog behaviour is set to 'Dockable').

see also bug #357631 for another issue depending on Dialog behaviour (shrinking dialog window size).

[jazzynico (jazzynico)]

Half-confirmed on Windows XP, Inkscape rev. 21865.
Double-click works, but tabs/pages are not remembered when windows set to floating.

[jazzynico (jazzynico)]

Still present in revision 11649.

"floating" is not the default setting, and it's a rather minor annoyance, thus I'm lowering importance to low.

[su_v (suv-lp)]

Proposing to raise importance again: in trunk rev 13262, the preferences dialog was changed to enforce 'floating' and to ignore the user prefs for dialog behavior. Now this bug affects every user and cannot be worked around (the preferences dialog cannot be switched back to dockable at runtime).

[jazzynico (jazzynico)]

Patch attached, please test!

The bug is related to the way signals are emitted. Inkscape should first initialize the pages and set the selection to the saved (in the preferences.xml file) value, and then call the on_changed signal on the TreeSelection when the selection is changed.

It works as expected when docked (now disabled), but with a floating dialog the signal_changed is called first.
According to the gtkmm documentation (https://developer.gnome.org/gtkmm/stable/classGtk_1_1TreeSelection.html#ad880fbe3cf130fe7c46f410b7efe3c0f):
"Emitted whenever the selection has (possibly) changed. Please note that this signal is mostly a hint. It may only be emitted once when a range of rows are selected, and it may occasionally be emitted when nothing has happened. "

[jazzynico (jazzynico)]

Tested on Crunchbang Waldorf and committed revision 13517.