Comment 12 for bug 179589

Revision history for this message
bbyak (buliabyak) wrote : Re: [Bug 179589] Re: PDF Import: spaces removed from font names

On Thu, Feb 12, 2009 at 4:18 PM, KoRi <email address hidden> wrote:
> Updated patch:
> - now checks that at least the first word of the font name matches.
> -> Would it be better if in case no matching font is found to just copy the (stripped) font-name from the pdf instead of setting the default (Arial) as is done now? (However this causes the font-selector to default to "sans", which seems impossible to change manually to another font easily).

that unchangeability of sans is a bug, certain to be fixed before
0.47, so yes, this is a more logical approach - let's not force
microsoft's arial on people, and try to preserve information as much
as possible

> -> Should there be a minimal number of matching characters in case the first 'word' of the font name is very short (eg. MV Boli)?

good idea - for example if first word is 3 chars or less (such as
ITC), require two words for a match

it will still break on Adobe Garamond though...

> - Improved the speed by only fetching the list with font names one time
> for each SvgBuilder instance. Should be reasonable now.

thanks, now much faster

> - as for '-inkscape-font-specification' ... I didn't change anything
> there (do not understand enough of how it works with
> PangoFontDescription and the changes related to Bug #169973). However
> when you say "... to store the exact font name as specified in PDF ..."
> that means without spaces and with style suffixes (eg.: TimesNewRomanPS-
> BoldItalicMT) as it is now, right?

yes

> Does it also need to include the
> prefixes that might be present in the pdf (eg.: DAAAAA+TimesNewRomanPS-
> BoldItalicMT) which is currently not the case?

no, i don't think these prefixes are proper part of the font name

> Hope I don't take too much of your time with all my questions ...

not at all, you're very welcome!

--
bulia byak
Inkscape. Draw Freely.
http://www.inkscape.org