Ugly Gtk triangle border in Color Wheel

[Bryce Harrington]

- When the fill&stroke dialog has focus, the GTK+ triangle
has some ugly non-antialiased one-pixel black border.
Without focus, it looks OK, no border.

This may be in GTK+ itself, in which case explore either
creating a Gtkmm subclass with better behavior, or send
a patch to the GTK crew that resolves this issue.

[Jon A. Cruz (jon-joncruz)]

Yes. The problem is in the standard GTK+ selector itself

[Horkana-users (horkana-users)]

shouldn't we punt this upstream to Gtk? (and close this request)

[Jon A. Cruz (jon-joncruz)]

That's not the standard GTK+ triangle, though the look is similar.

[Bug Importer (bug-importer)]

the cairo enabled version of the standard GTK colour picker
doesn't have antialiasing issues but I'd be repeating myself
if I pointed out the benefits of using standard components.

- Alan

[Jon A. Cruz (jon-joncruz)]

We try to use those when possible, however in the case of the color picker

we can't. The stock ones are very limited, and only good for RGB. They
can't handle the more complex concept of color that we need.

[nightrow (jb-benoit)]

Thank you for taking the time to report this bug and helping to make Inkscape better. You reported this bug a long while ago and there hasn't been any activity in it recently. We were wondering is this still an issue for you? Can you try with latest Inkscape release? Thanks in advance

[Bryce Harrington (bryce)]

Hi nightrow,

Yes, the problem is still there in 0.46, and still looks horky, sad to say. Probably this bug should be forwarded upstream to the Gtk bug tracker, since it's a widget system problem, not inkscape's fault.

[Jon A. Cruz (jon-joncruz)]

I think it might be in our code, not the stock GTK+ one. We do have our own triangle there, and I think that is the one that is not liked.

[Marcin Floryan (mfloryan)]

It is in widgets/sp-color-wheel.cpp if someone wants to have a look and indeed GtkColorSelection looks much smoother though I guess it contains way too many things to be used directly. Yet I would think it should be easy enough to port the GTK+ implementation to Inkscape.

[dopelover (dopelover)]

The triangle in Gimp looks perfect so maybe the best solution would be to figure out how the The Gimp's developers solved this issue?

[Alexandre Prokoudine (alexandre-prokoudine)]

2008-08-08 Michael Natterer <email address hidden>

        Bug #545990: GIMP color wheel is not antialiased

        * modules/colorsel_triangle.c: removed.

        * modules/colorsel_wheel.c: new module using the GtkHSV widget
        which was originally developed from above triangle selector.

        * modules/Makefile.am: changed accordingly.

[Justin Stressman (jstressman)]

I'm still seeing this on both 0.48.1 and 0.48+devel r9861 on Windows 7 64bit.

Clicking in either the triangle or the surrounding wheel causes that part of the color wheel to have a thick black aliased couple pixel wide border around it while it's focused. (switching focus to something else causes the border to disappear)

The color wheel itself (circle and triangle) is still aliased as well. I checked Gimp 2.6.8 (here on windows) and the color wheel there is smoothly antialiased and has no focus issues.

[Jon A. Cruz (jon-joncruz)]

Fixed in trunk revision 9941.

[LucaDC (lucadc)]

Problem compiling under Windows XP SP3:

Make error line 299: problem compiling: In file included from src/color-profile.h:12,
                 from src/widgets/sp-color-icc-selector.h:13,
                 from src/widgets/sp-color-wheel-selector.cpp:13:
c:\devlibs/include/lcms.h: In function 'void* _cmsMalloc(size_t)':
c:\devlibs/include/lcms.h:1410: warning: comparison of unsigned expression < 0 is always false
src/widgets/sp-color-wheel-selector.cpp: In function 'void handleWheelStyleSet(GtkHSV*, GtkStyle*, void*)':
src/widgets/sp-color-wheel-selector.cpp:141: error: 'gtk_widget_get_allocation' was not declared in this scope

[uwesch (uwesch)]

Same problem during compiling under Windows 7

[su_v (suv-lp)]

uwesch - which revision did you try on Windows 7?

r9943 should have taken care of this.

[su_v (suv-lp)]

> Fixed in trunk revision 9941.

Follow-up report:
Bug #687655 “New color wheel should not increase the width of docked Fill&Stroke dialog when scaled”
<https://bugs.launchpad.net/inkscape/+bug/687655>

[su_v (suv-lp)]

JFTR - as confirmed on irc by uwesch and in related question <https://answers.launchpad.net/inkscape/+question/137045> r9944 builds again on Windows without failure.

[LucaDC (lucadc)]

r9944 compiling ok under Windows XP SP3 too.
Thanks.

[su_v (suv-lp)]

Follow-up report related to the new color wheel code:
Bug #786892 “Gradient editor panel dialog is not resizing properly”
<https://bugs.launchpad.net/inkscape/+bug/786892>