Comment 11 for bug 1675755

Revision history for this message
David Mathog (mathog) wrote :

Oops, sorry, memory fart.

Are there any known locale issues in the code which are not related to the use of %f in a printf() statement? It seems likely that there are some C++ related ones resulting from one of these
types of conversion:

std::ostringstream astrstream;
astrstream << float_val;

std::string string_val = boost::lexical_cast<std::string>(float_val);

std::string string_val = to_string(float_val)

They will be harder to find since at the code line the name may not indicate that a float is involved, ie

   growing_svg << tmp;

Your global change will fix all of these. So let's stick with it.

The global change would also break the locale any float to string conversions which are supposed to land in the data part of a text string or a comment. Off the top of my head I cannot think of anywhere that happens in [EW]MF to SVG, but as we've just seen, my memory shouldn't always be trusted!