Comment 2 for bug 166720

Revision history for this message
Bpfowler (bpfowler) wrote :

Yes, it is from libart.

Yes, I would not be proposing to convert something to C++ just
for fun.

I would guess that most of the source to Inkscape is somewhere
on a spectrum between 'well-written' and 'in need of a
re-write';
whilst working code can be excused scrutiny, surely if a module
is so little needed that it is not worthwhile to re-write it for
consistency or to bump it along my spectrum then we should
be thinking about removing it altogether.

Is it intended to deprecate class NArtBpath in favour of
class Path?

There is another floating point equality at
svg/gnome-canvas-bpath-util.cpp at line 151

I have this method for the NR::Point class,
which tests whether two NR::Points are near each other:
    bool fNear( NR::Point pt, gdouble t) const {
        return ( fabs( _pt[X] - pt[X] ) <= t && fabs( _pt[Y]
- pt[Y] ) <= t );
    }