Toolbar icons have non-transparent backgrounds

[Tim Sheridan]

Initially reported here (with screenshot): https://bugs.launchpad.net/inkscape/+bug/1537497/comments/3

With the gtk3 build from trunk (0.93), following the patch adding background rendering to the Icon widget [1], toolbar icons no longer have transparent backgrounds. It's most obvious when using a dark UI theme.

The SVGs for Inkscape's UI icons need updating to have their background color alpha channel set to 0 so that they display correctly.

[1] https://code.launchpad.net/~tghs/inkscape/widget_icon_background_render/+merge/315514

[su_v (suv-lp)]

Proposed fix to change opacity of icons.svg page color to 0 confirmed and used independently on Ubuntu 14.04.5 LTS with lp:inkscape (see attached patch; also includes version bump to stop being prompted with dpi change dialog).

[jazzynico (jazzynico)]

Patch tested successfully on Xubuntu 16.04, lp:inkscape rev. 15485.

@su_v, is the patch yours or Tim's work? I know it's not very important for you, but it's just to be sure of the authorship before pushing to the trunk.

[su_v (suv-lp)]

@jazzynico - when I noticed the issue a few days ago, I did not know what exact change/commit introduced it, but I ended up with the same conclusion how to have the icons rendered without the solid document background color.

Attribute the fix to Tim. You can also skip the revbump for inkscape:version in the diff (I only noticed after uploading the diff that I left the ' custom' string in there unintentionally).

Note that there is a risk that the internal change not only breaks inkscape's own default icon set when used with a dark theme, but potentially any custom user icons.svg files out there currently in use (e.g. via ~/.config/inkscape/icons/icons.svg). If the solution remains to edit the icons file, and not to revert to how the icons had been rendered from such files in the past, then a special mention in the release notes (or 0.93) might be warranted.

[su_v (suv-lp)]

> assignee: Tim Sheridan (tghs) → nobody

Did I do something wrong? I apologize for attaching a diff to a report which was already assigned.

Besides the default icons, the alternative icons files distributed with Inkscape:
- share/icons/tango_icons.svg
- share/icons/symbolic_icons.svg
also have a solid background color, and could be adjusted the same way to provide icons with a transparent background.

For users with custom icons files which had been based on a copy of one of Inkscape's icons files, a short note could be added to the release notes for 0.93 to edit the background color accordingly (set alpha to 0).

[Tim Sheridan (tghs)]

su_v: No, not at all, cheers for the patch! Was just unassigning myself in case anyone else was getting annoyed by this bug and wanted go ahead with pushing a fix for this while I'm bogged down with working on the Mac 0.92.x builds. :-)

Turns out I need a break from that anyway (getting frustrating build reproduction inconsistencies between machines), so I'll reassign to me and push a branch with the fix for that and the rest of the files that you mention.

[jazzynico (jazzynico)]

FIxed in lp:inkscape rev. 15487.
Thanks!

[jazzynico (jazzynico)]

Note added to the 0.93 release notes (http://wiki.inkscape.org/wiki/index.php/Release_notes/0.93#Important_changes).