| 2016-11-02 06:55:09 |
su_v |
description |
Regression in current stable release branch (and possibly trunk): north, west and south quadrant points of ellipse/circle shapes no longer act as snap sources or targets. The east quadrant point is not affected.
Steps to reproduce:
1) launch inkscape (default new prefs, default new doc)
2) draw two circles
3) draw a rect
4) enable 'Snap smooth nodes, incl. quadrant points of ellipses' on the snap controls bar
5) grab a circle and snap it with one of the 3 mentioned quadrant points to another quadrant point or to a cusp node (corner) of the rectangle.
--> snapping fails
6) convert the selected circle to path
7) repeat step 5 with the converted path
--> snapping of smooth nodes works as expected unless the snap target is one of the 3 mentioned quadrant points of another ellipse/circle.
Based on tests with archived builds (on OS X 10.7.5):
- not reproduced with lp:inkscape/0.92.x rev <= 15058,
- reproduced with lp:inkscape/0.92.x rev >= 15066;
- reproduced with Inkscape 0.92pre2 (pre-release tar ball)
the regression was possibly exposed in r15064:
https://bazaar.launchpad.net/~inkscape.dev/inkscape/0.92.x/changes/15066
Revision r15064: Backport trunk 15063:
Use M_PI, M_PI_2. We use these constants everywhere so if they are not defined we are already in trouble.
No need to define them ourselves (except maybe in shared libraries).
https://bazaar.launchpad.net/~inkscape.dev/inkscape/0.92.x/revision/15064
https://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/15063
TODO: verify usage of 'M_2_PI' (code) vs 'M_PI_2' (commit message). |
Regression in current stable release branch (and possibly trunk): north, west and south quadrant points of ellipse/circle shapes no longer act as snap sources or targets. The east quadrant point is not affected.
Steps to reproduce:
1) launch inkscape (default new prefs, default new doc)
2) draw two circles
3) draw a rect
4) enable 'Snap smooth nodes, incl. quadrant points of ellipses' on the snap controls bar
5) grab a circle and snap it with one of the 3 mentioned quadrant points to another quadrant point or to a cusp node (corner) of the rectangle.
--> snapping fails
6) convert the selected circle to path
7) repeat step 5 with the converted path
--> snapping of smooth nodes works as expected unless the snap target is one of the 3 mentioned quadrant points of another ellipse/circle.
Based on tests with archived builds (on OS X 10.7.5):
- not reproduced with lp:inkscape/0.92.x rev <= 15058,
- reproduced with lp:inkscape/0.92.x rev >= 15066;
- reproduced with Inkscape 0.92pre2 (pre-release tar ball)
the regression was possibly exposed in r15064:
https://bazaar.launchpad.net/~inkscape.dev/inkscape/0.92.x/changes/15066
Revision r15064: Backport trunk 15063:
Use M_PI, M_PI_2. We use these constants everywhere so if they are not defined we are already in trouble.
No need to define them ourselves (except maybe in shared libraries).
https://bazaar.launchpad.net/~inkscape.dev/inkscape/0.92.x/revision/15064
https://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/15063 |
|
