Quadrant points of ellipse/circle fail to snap (as source or target)

Bug #1638472 reported by su_v
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
Medium
su_v

Bug Description

Regression in current stable release branch (and possibly trunk): north, west and south quadrant points of ellipse/circle shapes no longer act as snap sources or targets. The east quadrant point is not affected.

Steps to reproduce:
1) launch inkscape (default new prefs, default new doc)
2) draw two circles
3) draw a rect
4) enable 'Snap smooth nodes, incl. quadrant points of ellipses' on the snap controls bar
5) grab a circle and snap it with one of the 3 mentioned quadrant points to another quadrant point or to a cusp node (corner) of the rectangle.

--> snapping fails

6) convert the selected circle to path
7) repeat step 5 with the converted path

--> snapping of smooth nodes works as expected unless the snap target is one of the 3 mentioned quadrant points of another ellipse/circle.

Based on tests with archived builds (on OS X 10.7.5):
- not reproduced with lp:inkscape/0.92.x rev <= 15058,
- reproduced with lp:inkscape/0.92.x rev >= 15066;
- reproduced with Inkscape 0.92pre2 (pre-release tar ball)
the regression was possibly exposed in r15064:
https://bazaar.launchpad.net/~inkscape.dev/inkscape/0.92.x/changes/15066

Revision r15064: Backport trunk 15063:
Use M_PI, M_PI_2. We use these constants everywhere so if they are not defined we are already in trouble.
No need to define them ourselves (except maybe in shared libraries).
https://bazaar.launchpad.net/~inkscape.dev/inkscape/0.92.x/revision/15064
https://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/15063

su_v (suv-lp)
description: updated
Revision history for this message
su_v (suv-lp) wrote :

Proposed fix: partially revert earlier commit (M_2_PI is 2/pi, not 2*pi).

Revision history for this message
su_v (suv-lp) wrote :

Reproduced on Ubuntu 14.04 LTS with inkscape-trunk from PPA
  1:0.91.0+devel+15217+77~ubuntu14.04.1

Changed in inkscape:
status: New → Confirmed
Revision history for this message
jazzynico (jazzynico) wrote :

Bug also reproduced on Windows XP, lp:inkscape/0.92.x rev. 15155.
Works as expected with the fix from comment #1.
Thanks for the patch!

Changed in inkscape:
assignee: nobody → su_v (suv-lp)
importance: Undecided → Medium
milestone: none → 0.92
status: Confirmed → In Progress
Revision history for this message
jazzynico (jazzynico) wrote :

Fixed in lp:inkscape rev. 15226 and lp:inkscape/0.92.x rev. 15160.

Changed in inkscape:
status: In Progress → Fix Committed
Bryce Harrington (bryce)
Changed in inkscape:
status: Fix Committed → Fix Released
Revision history for this message
Geoff (gphillips) wrote :

This seems to affect me also, but NONE of a circle's (which has been converted to a path) nodes snap to the cusp node at the end of a line segment.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.