Comment 26 for bug 1621234

Revision history for this message
su_v (suv-lp) wrote :

Based on a few quick tests, it seems to me that the latest patch (fix-bug-1621234.v6.patch) avoids the issue of the erratic behavior in the node tool by avoiding the one known situation which can trigger it: the initial width of the pattern ('Ellipse') is actually '1.00' (again). The consequence: drawing a path with 'Ellipse' as shape produces different output (width of the pattern) depending on the internal drawing scale of the current document (not a setting exposed to the user apart from predefined templates). Compare for example (with default prefs) the result of a path drawn in default template (mm-based A4 page) to the result of a path drawn in a new document based on the template 'default px' (px-based A4 page). IIRC the commit for bug #172137 (in r14778) introduced the (down-)scaling (to produce identical output in both cases) - possibly that was not intentional after all?

To me personally, the last patch looks more like a workaround which hides what seemed to me like a troublesome interaction between path effect parameters, their representation in the Path Effects dialog and the node tool context. Since I do not know whether that issue could be exposed in other scenarios (not tied to the bezier/pencil shape), it's up to you what kind of fix to commit.