Comment 43 for bug 1488079

On 2015-12-27 10:53 (+0100), Alex Valavanis wrote:
> The patch isn't ideal, because it adds the GTKMM compiler flags to
> CPPFLAGS

Maybe I completely misunderstood that part of configure.ac: aren't the original CPPFLAGS restored unconditionally on line 1120 again? The diff only attempts to fix the check (test compilation) for the specific glibmm header (line 1119) which after r14542 fails with this error:

> conftest.cpp:117:10: fatal error: 'glibmm/threads.h' file not found
> #include <glibmm/threads.h>
> ^
> 1 warning and 1 error generated.

The header file is present (installed by glibmm), but after r14542 the '-I' flags for the conftest seem to be not ok (they now only have the flags for Gtk+, not for any C++ bindings).

Otherwise (if the cflags for gtkmm can't be included for a conftest compilation), that check should probably be removed from configure.ac altogether (line 1116-1120), along with the remaining use cases of HAVE_GLIBMM_THREADS_H (there are still those in src/widgets/sp-color-selector.{cpp,h} right now)?