Activity log for bug #1396372

Date Who What changed Old value New value Message
2014-11-25 22:41:26 su_v bug added bug
2014-11-25 22:42:47 su_v attachment added 1396372-fix-build-without-any-lcms-support-v1.diff https://bugs.launchpad.net/inkscape/+bug/1396372/+attachment/4268405/+files/1396372-fix-build-without-any-lcms-support-v1.diff
2014-11-25 22:47:02 su_v description A build configured to compile without any lcms support fails with: CXX svg/svg-color.o ../../src/svg/svg-color.cpp:359:9: error: use of undeclared identifier 'sp_color_hsl_to_rgb_floatv' sp_color_hsl_to_rgb_floatv( rgb, h, s, l ); ^ 1 error generated. make[3]: *** [svg/svg-color.o] Error 1 make[2]: *** [all] Error 2 make[1]: *** [all-recursive] Error 1 make: *** [all] Error 2 The attached patch was proposed by njh as fix in bug #1378843 and tested successfully on OS X 10.7.5, Inkscape 0.91+devel r13748 configured with '--enable-lcms=no' (using default autotools-based build system). A current trunk build configured to compile without any lcms support fails with:   CXX svg/svg-color.o ../../src/svg/svg-color.cpp:359:9: error: use of undeclared identifier 'sp_color_hsl_to_rgb_floatv'         sp_color_hsl_to_rgb_floatv( rgb, h, s, l );         ^ 1 error generated. make[3]: *** [svg/svg-color.o] Error 1 make[2]: *** [all] Error 2 make[1]: *** [all-recursive] Error 1 make: *** [all] Error 2 AFAICT the changes in rev 13466 introduced a dependency on "color.h" outside of LCMS/LCMS2 checks: http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/13466 The attached patch was proposed by njh as fix in bug #1378843 and tested successfully on OS X 10.7.5, Inkscape 0.91+devel r13748 configured with '--enable-lcms=no' (using default autotools-based build system).
2014-11-26 00:25:49 ScislaC inkscape: status New Fix Released
2014-11-26 00:25:56 ScislaC inkscape: importance Undecided Medium
2014-11-26 00:25:37 Launchpad Janitor branch linked lp:inkscape
2014-11-26 00:26:54 ScislaC inkscape: assignee njh (njh-njhurst)
2014-11-26 00:27:00 ScislaC inkscape: milestone 0.92
2014-11-26 00:38:48 su_v inkscape: milestone 0.92
2014-11-26 00:39:27 su_v tags build backport-proposed build
2014-11-26 00:41:15 su_v inkscape: status Fix Released Fix Committed
2014-11-26 00:41:15 su_v inkscape: milestone 0.92
2015-01-16 20:11:25 ScislaC inkscape: milestone 0.92 0.91
2015-01-16 20:52:37 su_v tags backport-proposed build build
2015-02-12 11:59:16 Alex Valavanis inkscape: status Fix Committed Fix Released