build failure with '--enable-lcms=no' (rev >= 13466)

Bug #1396372 reported by su_v
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
Medium
njh

Bug Description

A current trunk build configured to compile without any lcms support fails with:

  CXX svg/svg-color.o
../../src/svg/svg-color.cpp:359:9: error: use of undeclared identifier 'sp_color_hsl_to_rgb_floatv'
        sp_color_hsl_to_rgb_floatv( rgb, h, s, l );
        ^
1 error generated.
make[3]: *** [svg/svg-color.o] Error 1
make[2]: *** [all] Error 2
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

AFAICT the changes in rev 13466 introduced a dependency on "color.h" outside of LCMS/LCMS2 checks:
http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/13466

The attached patch was proposed by njh as fix in bug #1378843 and tested successfully on OS X 10.7.5, Inkscape 0.91+devel r13748 configured with '--enable-lcms=no' (using default autotools-based build system).

Tags: build
Revision history for this message
su_v (suv-lp) wrote :
description: updated
ScislaC (scislac)
Changed in inkscape:
status: New → Fix Released
importance: Undecided → Medium
assignee: nobody → njh (njh-njhurst)
milestone: none → 0.92
su_v (suv-lp)
Changed in inkscape:
milestone: 0.92 → none
tags: added: backport-proposed
Changed in inkscape:
milestone: none → 0.92
status: Fix Released → Fix Committed
Revision history for this message
ScislaC (scislac) wrote :

Backported in 0.91.x r13699.

Changed in inkscape:
milestone: 0.92 → 0.91
su_v (suv-lp)
tags: removed: backport-proposed
Changed in inkscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.