Comment 32 for bug 1269698

On 2016-05-28 02:32 (+0200), ScislaC wrote:
> su_v: At this point is this workaround something we should commit to
> trunk or just have the Windows and OSX packagers apply the patch to
> their builds?

For current OS X packaging, there's already a different workaround in
place (details/history on demand). For Windows packages, the workaround
could be patched in by the packagers, yes. Or it is simply applied to
Inkscape's icons file in the 0.92.x stable release branch once it has
been created (like for 0.91.1) - then packagers for the 0.92 series
would not have to bother.

I would still vote against applying the existing workaround to trunk:
1) It hides legacy stock icon names in use.
2) Directional icons still need fixing for RTL GUI.
3) Once Inkscape switches to GTK3, any packages for non-Linux desktops
(i.e. for Windows, OS X) will have to include the Adwaita icon theme
anyway (as a dependency of Gtk+ itself).
4) It's unclear at this point in time how Inkscape's own icons will be
maintained in the future (as is in a single custom icons file, or as
individual icon files in a "regular" gtk icon theme).

If considered helpful, I will provide an updated diff for icons.svg in
the upcoming 0.92.x stable release branch.