Live effects dont work in grouped shapes

Bug #1242170 reported by Jabiertxof
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
Medium
Jabiertxof

Bug Description

Live effects dont work on grouped shapes, yes ungruped.

Jabiertxof (jabiertxof)
Changed in inkscape:
assignee: nobody → Jabiertxof (jabiertxof)
tags: added: livepatheffects
Revision history for this message
Jabiertxof (jabiertxof) wrote :

Shapes like star, box...

tags: added: shapes
su_v (suv-lp)
tags: added: groups shape-editing
removed: shapes
su_v (suv-lp)
Changed in inkscape:
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Jabiertxof (jabiertxof) wrote :

There are two? roads to make it.
One is make LPE objects paths, like in 0.48.
The other is not, this is better, but need a lot of changes, maybe not necesary...

Revision history for this message
Jabiertxof (jabiertxof) wrote :

For the second option, think i need a new lpe unction tath return the lpeitem whith haspatheffect() recursive.
And some changes in the LPE part on al shapes code

Revision history for this message
Jabiertxof (jabiertxof) wrote :

This fix contains:
1.- the patch https://bugs.launchpad.net/inkscape/+bug/1247324
2.- A fix to avoid strange results on apply on nested groups, now take the lowest effet in the tree.
3.- Now apply Live Effects to stars, ellipses an spirals

Thanks to Johan Engelen and su_v for his help.

Revision history for this message
Jabiertxof (jabiertxof) wrote :

And rects whith the help of Johan Engelen

Revision history for this message
Jabiertxof (jabiertxof) wrote :

Point 3 apply to shapes inside a group, the only requisite is you can only apply one LPE list effect to each element in the tree, taking the lowest effect, the nearst or just the end shape.

Revision history for this message
Jabiertxof (jabiertxof) wrote :

Fix bug in mixed group contents (path/shapes)

Revision history for this message
Jabiertxof (jabiertxof) wrote :

Patchs dont working well,

Revision history for this message
Jabiertxof (jabiertxof) wrote :

Only one stack of effects can be applied to a shape -paths,star,ellipse,spiral-. This remove the strange effects in stable and trunk whith nested groups and disctint LPE applied in the tree. For now the lowest effect are applied. For example the effect nearest or be a star inside nested tree of a group.

Included two patch: Convert to shapes || Apply as shapes

1. Convert to shapes (LPE_fixes_and_convert_V1.diff):
Convert star, ellipse, rect and spiral to a path shape it this are inside a group and dont have a previous LPE.
Now correct recalculation of bbox if nore than one effects are in the stack.

2. Apply as shapes (LPE_fixes_and_non_convert_V1.diff):
Some positioning bugs cause not perfect behaviour, disctint than shapes converted to paths.
Some effects dont work well, for example lattice2 render bad with this patch.

After put the two patch...

Revision history for this message
Jabiertxof (jabiertxof) wrote :

Apply as shapes (LPE_fixes_and_non_convert_V1.diff)

Revision history for this message
Jabiertxof (jabiertxof) wrote :

Convert to paths (LPE_fixes_and_convert_V1.diff).

Revision history for this message
Jabiertxof (jabiertxof) wrote :

Sorry for the updates of pach. Now start versioning but i want a solid one base.

Revision history for this message
Jabiertxof (jabiertxof) wrote :

New version 2 of the patch.
Now has the ability to apply effects in diferent levels of the tree (group tree)
Again 2 roads:

1.- Apply as shapes (LPE_fixes_and_non_convert_V2.diff):
Some BBox problems.
Star, Ellipse and Spiral whith a LPE dont be affected by group LPE.

2.- Convert to paths (LPE_fixes_and_convert_V2.diff)
No bugs detected at now.

Files soon...

Revision history for this message
Jabiertxof (jabiertxof) wrote :

Apply as shapes (LPE_fixes_and_non_convert_V2.diff)

Revision history for this message
Jabiertxof (jabiertxof) wrote :

Convert to paths (LPE_fixes_and_convert_V2.diff)

Revision history for this message
Jabiertxof (jabiertxof) wrote :

New patch. Works the same but remove extra staff not necesary from non convert patch
Convert to paths (LPE_fixes_and_convert_V3.diff)

Revision history for this message
Jabiertxof (jabiertxof) wrote :

More cleanup

Jabiertxof (jabiertxof)
Changed in inkscape:
status: Confirmed → In Progress
Revision history for this message
Jabiertxof (jabiertxof) wrote :

Fixed in r.a113f466 of Master

Changed in inkscape:
status: In Progress → Fix Committed
Max Gaukler (mgmax)
Changed in inkscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.