trunk: new optimized transforms of shapes do not correctly propagate to path effects (rev >= 12554)

Bug #1247324 reported by su_v on 2013-11-02
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Medium
Jabiertxof

Bug Description

Affects Inkscape shapes (ellipse/circle, polygon/star) with path effects applied which are then transformed (translated, or rotated) with the selection tool. Affected LPEs:

Stable path effects:
- Bend
- Envelope Deformations
- VonKoch

Experimental path effects:
- Lattice Deformation
- Mirror symmetry
- Offset
- Rotate Copies

Steps to reproduce:
1) draw a star
2) apply Bend path effect
3) move the star

Expected result:
The object is moved to the new location, the output of the path effect is unchanged.

Actual result:
The bent shape snaps back to the original position. Removing the path effect will move the shape to the new location. Other path effects have distorted output (Lattice) or incorrect offsets (VonKoch).

Confirmed with r12761 on OS X 10.7.5.

Based on tests with archived builds:
- not reproduced with rev <= 12552,
- reproduced with rev >= 12554,
this regression was introduced with the changes in the merge of the GSoC unit-improvement branch in revision 12554:
<http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/12554>

su_v (suv-lp) on 2013-11-02
description: updated
jazzynico (jazzynico) wrote :

Reproduced on Windows XP, Inkscape trunk revision 12774.

Changed in inkscape:
status: New → Triaged
Jabiertxof (jabiertxof) wrote :

Reproduced on Debian 7 64 bits revision 12774

Jabiertxof (jabiertxof) wrote :

The bug dont appear in translated shapes is a problem in the function "set_transform" of spiral, star/polygon and circle/ellipse.

Changed in inkscape:
assignee: nobody → Jabiertxof (jabiertxof)
Jabiertxof (jabiertxof) wrote :

This fixes the problem. By adding transform to LPE shapes.

Jabiertxof (jabiertxof) on 2013-12-20
Changed in inkscape:
status: Triaged → In Progress
Bryce Harrington (bryce) wrote :

@suv, would you mind testing the patch Jabiertxof posted and verify it as a fix? The code looks sensible to me on cursory review of the patch.

su_v (suv-lp) wrote :

Patch tested successfully with r12881 on OS X 10.7.5 and committed in revision 12884.

@Jabiertxof - many thanks for the patch!

Changed in inkscape:
status: In Progress → Fix Committed
Bryce Harrington (bryce) on 2015-02-23
Changed in inkscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers