Comment 10 for bug 1043571

Revision history for this message
Kris (kris-degussem) wrote :

I have difficulties understanding what you mean (comment 8).
If I'm right, you tested with trunk revision 11679, which does not include the modifications of the patch (committed in revision 11686).

1. is a new issue. I will have a look at it. There is a memory leak at line 367 ("value_unquoted = g_strndup(value_unquoted, l-2);"). Will see whether using the Glib::ustring class as alternative to C-strings can be used.

2. is the original issue of this report. I'm not sure it is solved with revision 11686 (I actually doubt). If not solved, it should be checked whether the share_string function (used on line 375 of xml/simple-node.cpp) could be converted to use c++ string classes as opposed to C-strings/shared pointer strings.