Luca Bruno wrote:
> As we're using older poppler libs on various architecture
> (prominently 0.12 in windows devlibs), I'd suggest going for
> conditional building instead.
>
> The attached patch works both with newer and older poppler version,
> and it's up for review. If no objections received, I'm going to
> commit this to trunk in a couple of days.
The changes to 'src/extension/internal/pdfinput/svg-builder.cpp' are not conditional - are there any test cases around to confirm that switching from 'getOrigName()' to 'getName()' has no adverse side-effects with older poppler versions?
Luca Bruno wrote:
> As we're using older poppler libs on various architecture
> (prominently 0.12 in windows devlibs), I'd suggest going for
> conditional building instead.
>
> The attached patch works both with newer and older poppler version,
> and it's up for review. If no objections received, I'm going to
> commit this to trunk in a couple of days.
The changes to 'src/extension/ internal/ pdfinput/ svg-builder. cpp' are not conditional - are there any test cases around to confirm that switching from 'getOrigName()' to 'getName()' has no adverse side-effects with older poppler versions?