Comment 2 for bug 944253

Revision history for this message
Charles Kerr (charlesk) wrote :

I'm still just learning vala so I could be wrong, but I think Coverity is correct.

The vala code that generated the C that Coverity is warning is:

  public void alter_label (string new_title)
  {
    if (new_title == null) return;
    this.property_set (MENUITEM_PLAYER_NAME, new_title);
  }

I think "new_title" isn't allowed to be null because it's not prefixed with '?' in the argument list.

Removing the "if (new_title == null) return;" line removes the C code that generated the Coverity warning.