Comment 147 for bug 2034477

(In reply to Mario Limonciello (AMD) from comment #66)
> David can you check if reverting e179f6914152 fixes this issue? I would
> think it's still broken without the missing sequence.

The code has changed since 2014, when that commit was made, so it no longer reverts cleanly, and I had to do it by hand. The kernel is still compiling, and I'll post the results when that's done, but I wanted to confirm that you just want me to remove the probing code. This is what probe_8259A() looks in my test:

static int probe_8259A(void)
{
        unsigned long flags;
        raw_spin_lock_irqsave(&i8259A_lock, flags);

        outb(0xff, PIC_MASTER_IMR); /* mask all of 8259A-1 */
        outb(0xff, PIC_SLAVE_IMR); /* mask all of 8259A-2 */

        raw_spin_unlock_irqrestore(&i8259A_lock, flags);
        return nr_legacy_irqs();
}

Basically, it never touches legacy_pic.

> OK then there is a secondary issue with the BIOS configuration and usage of
> the IOMMU.
> Let's treat it separately from this issue.

Should I file a separate bug for that?