Comment 2 for bug 2054391

Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

Thanks for the patch @Kai-Heng! I took a look and in general it looks good, but I'd like to ask you to add some DEP-3 headers [1] to your patch, that will give us (packagers) more context when revisiting this package for whatever reason.

Now a personal opinion, I like when the patch file name is listed in the changelog entry ("* d/p/0016-Fixed-enumeration-of-cpu-thermal-sensors.patch: <what_this_is_fixing>"). It makes a direct link between the change listed there and the file actually fixing it.

Once you address my first comment at least (the second one is not mandatory), please subscribe ~ubuntu-sponsors again (I am unsubscribing it now).

[1] https://dep-team.pages.debian.net/deps/dep3/