this review is about the ivsc-driver portion of this SRU, which I will paste below and add inline comments to:
> ========== ivsc-driver ==========
>
> [Impact]
>
> Missing Intel MIPI firmware for Meteor Lake platform.
The patches added to the ivsc-driver package do not seem to be about a missing firmware, like the impact section above claims:
+ - ljca: try to find acpi device from hub device
+ - mei-vsc: port mei api change in v6.2
+ - mfd: ljca: Fix try_match_acpi_hid return value checking
+ - misc: spi-vsc: Fix cvfd_ids array with terminator
Please clarify.
>
> [Fix]
>
> 4 commits from the latest trunk branch on upstream repository https://github.com/intel/ivsc-driver.
>
> [Test Case]
>
> With all other changes in position, Intel VSC driver modules are to be loaded as a soft dependency of some selected camera sensor modules. LJCA modules should be loaded automatically on MTL platforms as well.
>
> To actually verify the camera framework:
> ```
> $ sudo add-apt-repository ppa:oem-solutions-group/intel-ipu6
> $ sudo add-apt-repository ppa:canonical-hwe-team/intermediate-kernel
> $ sudo apt install linux-oem-22.04d-exp
> $ sudo apt install linux-modules-ipu6-oem-22.04d-exp
> $ sudo apt install linux-modules-ivsc-oem-22.04d-exp
> $ sudo apt install linux-modules-usbio-oem-22.04d-exp
> $ sudo apt install gstreamer1.0-icamera v4l2-relayd
> ```
This is problematic: why do we have to add ppas, and install other kernel modules? Can you come up with a test case that does NOT need packages from an out-of-archive source? And specifically, using the mantic kernel (6.5). Is there another way to test it? Why do we need so many out-of-archive components?
If pure mantic with the updated ivsc-driver and ipu6-drivers packages from this bug is not enough to support the MIPI camera, then what is the benefit this SRU is bringing to mantic users?
> And then browse https://webcamtests.com/ for testing.
>
> [Where problems could occur]
>
> While it changes how LJCA modules match from ACPI ID, it's also tested and verified on previous generations using IVSC, e.g. TGL, ADL.
>
> [Other Info]
>
> While Intel Meteor Lake is only supported by linux-oem-6.5/jammy and
> linux/mantic and on, and yet the lastest stable driver was verified after Mantic was released, it's being proposed to Noble instead.
Not sure what you mean with the above. I see the same fixes proposed for mantic landed in noble, so that's good. Maybe the comment above was written before the noble packages were updated?
Hi,
this review is about the ivsc-driver portion of this SRU, which I will paste below and add inline comments to:
> ========== ivsc-driver ==========
>
> [Impact]
>
> Missing Intel MIPI firmware for Meteor Lake platform.
The patches added to the ivsc-driver package do not seem to be about a missing firmware, like the impact section above claims:
+ - ljca: try to find acpi device from hub device
+ - mei-vsc: port mei api change in v6.2
+ - mfd: ljca: Fix try_match_acpi_hid return value checking
+ - misc: spi-vsc: Fix cvfd_ids array with terminator
Please clarify.
> /github. com/intel/ ivsc-driver. solutions- group/intel- ipu6 hwe-team/ intermediate- kernel 22.04d- exp ipu6-oem- 22.04d- exp ivsc-oem- 22.04d- exp usbio-oem- 22.04d- exp 0-icamera v4l2-relayd
> [Fix]
>
> 4 commits from the latest trunk branch on upstream repository https:/
>
> [Test Case]
>
> With all other changes in position, Intel VSC driver modules are to be loaded as a soft dependency of some selected camera sensor modules. LJCA modules should be loaded automatically on MTL platforms as well.
>
> To actually verify the camera framework:
> ```
> $ sudo add-apt-repository ppa:oem-
> $ sudo add-apt-repository ppa:canonical-
> $ sudo apt install linux-oem-
> $ sudo apt install linux-modules-
> $ sudo apt install linux-modules-
> $ sudo apt install linux-modules-
> $ sudo apt install gstreamer1.
> ```
This is problematic: why do we have to add ppas, and install other kernel modules? Can you come up with a test case that does NOT need packages from an out-of-archive source? And specifically, using the mantic kernel (6.5). Is there another way to test it? Why do we need so many out-of-archive components?
If pure mantic with the updated ivsc-driver and ipu6-drivers packages from this bug is not enough to support the MIPI camera, then what is the benefit this SRU is bringing to mantic users?
> And then browse https:/ /webcamtests. com/ for testing.
>
> [Where problems could occur]
>
> While it changes how LJCA modules match from ACPI ID, it's also tested and verified on previous generations using IVSC, e.g. TGL, ADL.
>
> [Other Info]
>
> While Intel Meteor Lake is only supported by linux-oem-6.5/jammy and
> linux/mantic and on, and yet the lastest stable driver was verified after Mantic was released, it's being proposed to Noble instead.
Not sure what you mean with the above. I see the same fixes proposed for mantic landed in noble, so that's good. Maybe the comment above was written before the noble packages were updated?