device doesn't boot with kernel older than v5.7.7 on a usb key: hang at efi_tpm_eventlog_init

[You-Sheng Yang]

[SRU Justification]

[Impact]
Some systems may hang at boot. With "earlycon=efifb", more debug
messages for EFI are dumpped. Last call trace as:

  RIP: 0010:efi_tpm_eventlog_init+0x1aa/0x2a2
  ...
  Call Trace:
   efi_config_parse_tables+0x12d/0x213
   efi_init+0x218/0x36b
   ? e820__print_table+0x65/0x6e
   setup_arch+458/0xa84

This affects all mainline kernel since v5.2 to v5.7.6. Fix available in
v5.8-rc3 and has been backported to v5.7.7, v5.4.50.

[Fix]
Commit ea3cdcaa43b0 ("efi/tpm: Verify event log header before parsing")
fixes commit 6b0326190205 ("efi: Attempt to get the TCG2 event log in
the boot stub").

[Test Case]
So far it can be easily reproduced with a green installation of Focal on
USB key on a few Dell platforms.

[Regression Potential]
Low. This checks validity of tmp event log header before parsing them,
so it affects only platforms might generate invalid entries only.

[Other Info]
This affects -generic for eoan and oem-5.6 for focal, but the former has
be EOL-ed.

========== Original Bug Description ==========

[Summary] device doesn't boot with kernel older than v5.7.7 on USB key

[Steps to reproduce]
1. Try to boot a green installation of Ubuntu Focal on a USB key.

[Expected result]
Boot up normally.

[Actual result]
Stuck at "loading initial ramdisk". With "earlycon=efifb", more debug messages for EFI are dumpped. Last call trace as:

  RIP: 0010:efi_tpm_eventlog_init+0x1aa/0x2a2
  ...
  Call Trace:
   efi_config_parse_tables+0x12d/0x213
   efi_init+0x218/0x36b
   ? e820__print_table+0x65/0x6e
   setup_arch+458/0xa84

[Failure rate]
10/10

[Additional information]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ea3cdcaa43b08c9a747639f545b0ed5cca47f87e ("efi/tpm: Verify event log header before parsing") fixes in 6b0326190205 ("efi: Attempt to get the TCG2 event log in the boot stub").

The fix is in linux-5.7.y and v5.8-rc3, and focal 5.4 and oem-5.6 are affected.

ProblemType: Bug
DistroRelease: Ubuntu 20.04
Package: linux-image-5.8.0-16-generic 5.8.0-16.17
ProcVersionSignature: Ubuntu 5.8.0-16.17-generic 5.8.0
Uname: Linux 5.8.0-16-generic x86_64
NonfreeKernelModules: zfs zunicode zavl icp zcommon znvpair
ApportVersion: 2.20.11-0ubuntu27.6
Architecture: amd64
AudioDevicesInUse: Error: command ['fuser', '-v', '/dev/snd/by-path', '/dev/snd/controlC0', '/dev/snd/hwC0D0', '/dev/snd/hwC0D2', '/dev/snd/pcmC0D5p', '/dev/snd/pcmC0D4p', '/dev/snd/pcmC0D3p', '/dev/snd/pcmC0D1c', '/dev/snd/pcmC0D1p', '/dev/snd/pcmC0D0c', '/dev/snd/pcmC0D0p', '/dev/snd/seq', '/dev/snd/timer'] failed with exit code 1:
CasperMD5CheckResult: skip
Date: Tue Aug 25 02:51:58 2020
InstallationDate: Installed on 2020-07-21 (35 days ago)
InstallationMedia: Ubuntu 20.04 LTS "Focal Fossa" - Release amd64 (20200423)
MachineType: Dell Inc. Inspiron 3500
ProcEnviron:
 TERM=xterm-256color
 PATH=(custom, no user)
 LANG=en_US.UTF-8
 SHELL=/bin/bash
ProcFB: 0 i915drmfb
ProcKernelCmdLine: BOOT_IMAGE=/boot/vmlinuz-5.8.0-16-generic root=UUID=7c53c615-c466-43d7-9ca3-f8b8d895b7b0 ro initcall_debug debug
PulseList: Error: command ['pacmd', 'list'] failed with exit code 1: No PulseAudio daemon running, or not running as session daemon.
RelatedPackageVersions:
 linux-restricted-modules-5.8.0-16-generic N/A
 linux-backports-modules-5.8.0-16-generic N/A
 linux-firmware 1.187.2
SourcePackage: linux
UpgradeStatus: No upgrade log present (probably fresh install)
dmi.bios.date: 08/05/2020
dmi.bios.release: 0.4
dmi.bios.vendor: Dell Inc.
dmi.bios.version: 0.4.3
dmi.board.vendor: Dell Inc.
dmi.chassis.type: 10
dmi.chassis.vendor: Dell Inc.
dmi.modalias: dmi:bvnDellInc.:bvr0.4.3:bd08/05/2020:br0.4:svnDellInc.:pnInspiron3500:pvr:rvnDellInc.:rn:rvr:cvnDellInc.:ct10:cvr:
dmi.product.family: Inspiron
dmi.product.name: Inspiron 3500
dmi.product.sku: 0A25
dmi.sys.vendor: Dell Inc.

[Ubuntu Kernel Bot (ubuntu-kernel-bot)]

This change was made by a bot.

[You-Sheng Yang (vicamo)]

Focal fixed this in 5.4.0-44 (in proposed).

[You-Sheng Yang (vicamo)]

SRU: https://lists.ubuntu.com/archives/kernel-team/2020-August/112941.html
PPA: https://launchpad.net/~vicamo/+archive/ubuntu/ppa-1892827

[You-Sheng Yang (vicamo)]

SRU v2: https://lists.ubuntu.com/archives/kernel-team/2020-August/112992.html

[You-Sheng Yang (vicamo)]

No change resubmit, so PPA not rebuilt.

[Ubuntu Kernel Bot (ubuntu-kernel-bot)]

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal' to 'verification-done-focal'. If the problem still exists, change the tag 'verification-needed-focal' to 'verification-failed-focal'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

[You-Sheng Yang (vicamo)]

Verified linux-oem-5.6 version 5.6.0-1028.28 from focal-proposed.

[Launchpad Janitor (janitor)]

This bug was fixed in the package linux-oem-5.6 - 5.6.0-1028.28

---------------
linux-oem-5.6 (5.6.0-1028.28) focal; urgency=medium

  * focal/linux-oem-5.6: 5.6.0-1028.28 -proposed tracker (LP: #1894630)

  * Cannot probe sata disk on sata controller behind VMD: ata1.00: failed to
    IDENTIFY (I/O error, err_mask=0x4) (LP: #1894778)
    - SAUCE: PCI: vmd: Add AHCI to fast interrupt list

  * SRU: Fix system hang when stress S3 on radeon with TTM (LP: #1893609)
    - mei: bus: don't clean driver pointer

  * Packaging resync (LP: #1786013)
    - [Packaging] update helper scripts
    - update dkms package versions

  * Introduce the new NVIDIA 450-server and the 450 UDA series (LP: #1887674)
    - [packaging] add signed modules for the 450 nvidia driver

  * CVE-2020-12888
    - vfio/type1: Support faulting PFNMAP vmas
    - vfio-pci: Fault mmaps to enable vma tracking
    - vfio-pci: Invalidate mmaps and block MMIO access on disabled memory

  * Missing id 8086:a0bc for VMD quirk PCI_DEV_FLAGS_ENABLE_ASPM (LP: #1893194)
    - SAUCE: PCI/ASPM: VMD: add ASPM quirk for 8086:a0bc

  * The DP/HDMI audio via USB-C to DP dongle or Dell Zeus adapter can't work
    after suspend (LP: #1893290)
    - ALSA: hda/hdmi: always check pin power status in i915 pin fixup

  * Comet Lake PCH-H RAID not support on Ubuntu20.04 (LP: #1892288)
    - ahci: Add Intel Comet Lake PCH-H PCI ID

  * device doesn't boot with kernel older than v5.7.7 on a usb key: hang at
    efi_tpm_eventlog_init (LP: #1892827)
    - efi/tpm: Verify event log header before parsing

 -- Timo Aaltonen <email address hidden> Tue, 08 Sep 2020 11:40:14 +0300