Comment 5 for bug 1489154

Revision history for this message
A. Eibach (andi3) wrote :

OK, so "my" bug must be in ./NetworkManager/libnm/nm-device-wifi.c

in the function as follows:

prepare_scan_options (GVariant *options)
{
 ..

if (!options)
    284 variant = g_variant_new_array (G_VARIANT_TYPE ("{sv}"), NULL, 0);
    285 else {
    286 g_variant_builder_init (&builder, G_VARIANT_TYPE_VARDICT);
    287 g_variant_iter_init (&iter, options);
    288 while (g_variant_iter_loop (&iter, "{sv}", &key, &value))
    289 {
    290 // FIXME: verify options here?
    291 g_variant_builder_add (&builder, "{sv}", key, value);
    292 }
    293 variant = g_variant_builder_end (&builder);
    294 }
...
}

Heh...

// FIXME: verify options here?

Yes, that would be a good idea. Otherwise things like these here may happen. :-]