Comment 5 for bug 1938453

Revision history for this message
Badshah400 (badshah400) wrote :

Thanks for the suggestions. All implemented, except...

> For Nona and align_image_stack you can also trying to switch to egl by adding -DBUILD_WITH_EGL=on to the CMake command line.

When I do this, the build fails because the linker no longer links against X11. Seems this in the CMakeLists.txt fixes the linking problem and the build works again, but the `NOT HAVE_EGL` is probably there for a reason:

```
-IF(NOT APPLE AND NOT WIN32 AND NOT HAVE_EGL)
+IF(NOT APPLE AND NOT WIN32)
 MESSAGE(STATUS "Searching X11 header")
 FIND_PACKAGE(X11 REQUIRED)
 ENDIF()

```

Error log:

```
[ 39s] /var/lib/build/ccache/bin/c++ -fPIC -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -g -DNDEBUG -pthread -O2 -g -DNDEBUG -flto=auto -Wl,--as-needed -Wl,--no-undefined -Wl,-z,now -fopenmp -shared -Wl,-soname,libhuginbasewx.so.0.0 -o libhuginbasewx.so.0.0 CMakeFiles/huginbasewx.dir/wxImageCache.cpp.o CMakeFiles/huginbasewx.dir/MyProgressDialog.cpp.o CMakeFiles/huginbasewx.dir/PTWXDlg.cpp.o CMakeFiles/huginbasewx.dir/huginConfig.cpp.o CMakeFiles/huginbasewx.dir/MyExternalCmdExecDialog.cpp.o CMakeFiles/huginbasewx.dir/platform.cpp.o CMakeFiles/huginbasewx.dir/RunStitchPanel.cpp.o CMakeFiles/huginbasewx.dir/LensTools.cpp.o CMakeFiles/huginbasewx.dir/wxLensDB.cpp.o CMakeFiles/huginbasewx.dir/HFOVDialog.cpp.o CMakeFiles/huginbasewx.dir/Command.cpp.o CMakeFiles/huginbasewx.dir/PanoCommand.cpp.o CMakeFiles/huginbasewx.dir/wxPanoCommand.cpp.o CMakeFiles/huginbasewx.dir/CommandHistory.cpp.o CMakeFiles/huginbasewx.dir/Executor.cpp.o CMakeFiles/huginbasewx.dir/AssistantExecutor.cpp.o CMakeFiles/huginbasewx.dir/StitchingExecutor.cpp.o CMakeFiles/huginbasewx.dir/wxcms.cpp.o CMakeFiles/huginbasewx.dir/wxPlatform.cpp.o CMakeFiles/huginbasewx.dir/GraphTools.cpp.o -Wl,-rpath,/home/abuild/rpmbuild/BUILD/hugin-2020.0.0/build/src/hugin_base: -L/usr/lib64 -pthread -lwx_baseu-3.1 -lwx_gtk3u_core-3.1 -lwx_gtk3u_aui-3.1 -lwx_gtk3u_xrc-3.1 -lwx_gtk3u_html-3.1 -lwx_baseu_xml-3.1 -lwx_gtk3u_gl-3.1 -lwx_baseu_net-3.1 -lwx_gtk3u_qa-3.1 ../../hugin_base/libhuginbase.so.0.0 /usr/lib64/libpano13.so ../../foreign/levmar/libhuginlevmar.a /usr/lib64/libGLEW.so /usr/lib64/libboost_filesystem.so.1.76.0 /usr/lib64/libboost_system.so.1.76.0 /usr/lib64/liblapack.so /usr/lib64/libblas.so /usr/lib64/libfftw3.so /usr/lib64/libvigraimpex.so /usr/lib64/libImath-2_5.so /usr/lib64/libIlmImf-2_5.so /usr/lib64/libIex-2_5.so /usr/lib64/libHalf-2_5.so /usr/lib64/libIlmThread-2_5.so /usr/lib64/libz.so /usr/lib64/libjpeg.so /usr/lib64/libtiff.so /usr/lib64/libpng.so /usr/lib64/libz.so /usr/lib64/libz.so /usr/lib64/libexiv2.so /usr/lib64/liblcms2.so /usr/lib64/libjpeg.so /usr/lib64/libpng.so /usr/lib64/libtiff.so /usr/lib64/libexiv2.so -pthread /usr/lib64/libOpenGL.so /usr/lib64/libGLX.so /usr/lib64/libGLU.so /usr/lib64/libEGL.so /usr/lib64/libGLEW.so /usr/lib64/libsqlite3.so /usr/lib64/liblcms2.so
[ 39s] /usr/lib64/gcc/x86_64-suse-linux/11/../../../../x86_64-suse-linux/bin/ld: /tmp/ccHfmLJI.ltrans10.ltrans.o: in function `HuginBase::Color::detail::GetProfileFromAtom(_XDisplay*, char const*)':
[ 39s] /home/abuild/rpmbuild/BUILD/hugin-2020.0.0/src/hugin1/base_wx/wxcms.cpp:66: undefined reference to `XInternAtom'
[ 39s] /usr/lib64/gcc/x86_64-suse-linux/11/../../../../x86_64-suse-linux/bin/ld: /home/abuild/rpmbuild/BUILD/hugin-2020.0.0/src/hugin1/base_wx/wxcms.cpp:74: undefined reference to `XDefaultRootWindow'
[ 39s] /usr/lib64/gcc/x86_64-suse-linux/11/../../../../x86_64-suse-linux/bin/ld: /home/abuild/rpmbuild/BUILD/hugin-2020.0.0/src/hugin1/base_wx/wxcms.cpp:77: undefined reference to `XGetWindowProperty'
[ 39s] /usr/lib64/gcc/x86_64-suse-linux/11/../../../../x86_64-suse-linux/bin/ld: /home/abuild/rpmbuild/BUILD/hugin-2020.0.0/src/hugin1/base_wx/wxcms.cpp:84: undefined reference to `XFree'
[ 39s] /usr/lib64/gcc/x86_64-suse-linux/11/../../../../x86_64-suse-linux/bin/ld: /tmp/ccHfmLJI.ltrans10.ltrans.o: in function `HuginBase::Color::detail::GetMonitorProfile(wxString&, void*&)':
[ 39s] /home/abuild/rpmbuild/BUILD/hugin-2020.0.0/src/hugin1/base_wx/wxcms.cpp:99: undefined reference to `XOpenDisplay'
[ 39s] /usr/lib64/gcc/x86_64-suse-linux/11/../../../../x86_64-suse-linux/bin/ld: /home/abuild/rpmbuild/BUILD/hugin-2020.0.0/src/hugin1/base_wx/wxcms.cpp:112: undefined reference to `XSync'
[ 39s] /usr/lib64/gcc/x86_64-suse-linux/11/../../../../x86_64-suse-linux/bin/ld: /home/abuild/rpmbuild/BUILD/hugin-2020.0.0/src/hugin1/base_wx/wxcms.cpp:113: undefined reference to `XCloseDisplay'
[ 39s] collect2: error: ld returned 1 exit status
[ 39s] make[2]: *** [src/hugin1/base_wx/CMakeFiles/huginbasewx.dir/build.make:438: src/hugin1/base_wx/libhuginbasewx.so.0.0] Error 1
[ 39s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/hugin-2020.0.0/build'
[ 39s] make[1]: *** [CMakeFiles/Makefile2:1456: src/hugin1/base_wx/CMakeFiles/huginbasewx.dir/all] Error 2
[ 39s] make: *** [Makefile:159: all] Error 2
```