please move udev rules to /lib/udev/rules.d

[Jiri Popelka]

udev rules should be placed in /lib/udev/rules.d/, not in /etc.
/etc is reserved for admins to overwrite udev config shipped by packages.
It should not be used by packages directly.

[Ben Sagal (bensagal)]

udev looks for rules in 2 locations /etc/udev/rules.d/ and /lib/udev/rules.d/.
system defined rules are supposed to be installed in /lib/udev/rules.d/ and not in etc, however hplip installs the rules into /etc/udev/rules.d/.

Reproducible: Always

checked with virstion 3.10.9

[Billie-gentoo (billie-gentoo)]

Please open a bug upstream at https://launchpad.net/hplip about this issue and report the bug number here. Thank you.

[Billie-gentoo (billie-gentoo)]

Seems like there is already a bug [1] with a comment from you.

[1] https://bugs.launchpad.net/hplip/+bug/500086

[Billie-gentoo (billie-gentoo)]

Created attachment 254547
hplip-3.10.9-udev-rules-install-path.patch

Attached patch to the current hplip ebuild should replace all occurrences of "/etc/udev/rules.d" with "/lib/udev/rules.d".

[Ben Sagal (bensagal)]

Created attachment 254991
update patch

the patch should really use $(get_libdir) instead of lib (as amd64 use lib64 not lib), fixed in update patch.

Apart from tat original patch works, thanks.

[Billie-gentoo (billie-gentoo)]

(In reply to comment #4)
> the patch should really use $(get_libdir) instead of lib (as amd64 use lib64
> not lib), fixed in update patch.
>
> Apart from tat original patch works, thanks.

You are correct. My sed was more a quick hack to test if it works. I don't think I will add it to the ebuild. This should be fixed in an upstream release.

[Diego Elio Pettenò (flameeyes)]

I'm partial at adding this to the ebuild already, given that right now on update we're asking users to ack the changes.

[Billie-gentoo (billie-gentoo)]

(In reply to comment #6)
> I'm partial at adding this to the ebuild already, given that right now on
> update we're asking users to ack the changes.
>

If you want to add it just uncomment the relevant lines in the ebuilds, as the sed is already there. If you prefer a patch feel free to create one. I became a bit cautious about adding unconfirmed patches (which are not that important), as upstream is tad slow with integrating them, and I don't want to recreate them with every new release. Especially when upstream is switching eol-markers from LF to CRLF back and forth.

[Diego Elio Pettenò (flameeyes)]

Can I ask you please to enable the sed then? I'm unable to connect to CVS :(

And totally agree about avoiding patch files.

[Billie-gentoo (billie-gentoo)]

(In reply to comment #8)
> Can I ask you please to enable the sed then? I'm unable to connect to CVS :(
>
> And totally agree about avoiding patch files.
>

+*hplip-3.11.1-r1 (26 Jan 2011)
+
+ 26 Jan 2011; Daniel Pielmeier <email address hidden> -hplip-3.11.1.ebuild,
+ +hplip-3.11.1-r1.ebuild:
+ Revision bump to fix bug #345725. Thanks to Ben Sagal for reporting.

Fixed in cvs for hplip-3.11.1-r1. Closing this one for now. I will watch the upstream bug. Let's see how long it takes until they fix it.

[Amarnath Chitumalla (amarnath-chitumalla)]

Hi Jiri Popelka,

Thank you for providing the information.
As per the udev man page, /etc/udev/rules.d is the package or custom rules directory. So we don't see any issue in this.

Please let us know if you have any further information.

Thanks & Regards,
Amarnath

[Daniel Pielmeier (daniel-pielmeier)]

I second this. Udev rules installed by packages should go to /lib/udev/rules.d/. /etc/udev/rules.d/ is for the user/administrator where she can overwrite the rules from /lib.

PS:There is already bug #500086 open about this topic. It deals with the rules installed by hplip and the plugin package.