Comment 2 for bug 1916397

Revision history for this message
zdohnal (zdohnal) wrote :

Hi Shivani,

thank you for responding to this bug.

IMHO the bug is still valid for several reasons:

1) The source tarball must contain only files needed for compilation and installation and all binaries must be created via compilation - locatedriver and print plugins violate this rule.

2) 'locatedriver' binary can be created by compilation of hplip, but having it precompiled in a source tarball is against of what source tarball must contain (it is called 'source' and 'locatedriver' isn't a source file, it's a product of compilation).
Plus serving 'locatedriver' as a precompiled binary doesn't work across all platforms... it will work only on OSes which have the same libraries which you compiled 'locatedriver' with right now. If a platform will have a newer/older libs than you used during compilation, locatedriver will not work for them.

3) would you mind directing me to the source files of print plugins in HPLIP source tarball? Unfortunately I haven't been able to find print plugins source files in HPLIP source tarball... if there aren't any, then print plugins aren't open sourced - only adding precompiled shared objects to the source tarball unfortunately doesn't make them open source.

Thank you for all your work and looking into this issue!

Zdenek